Fix URL resolution for subpath base URLs in Helm downloads#292
Open
ejaifeobuks wants to merge 1 commit into
Open
Fix URL resolution for subpath base URLs in Helm downloads#292ejaifeobuks wants to merge 1 commit into
ejaifeobuks wants to merge 1 commit into
Conversation
Ensure downloadBaseURL ends with '/' before URL resolution so a subpath mirror (e.g. https://example/kubernetes/helm) is preserved instead of having its last path segment replaced. Fixes downloads for all subpath mirrors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with constructing Helm download URLs when a custom base URL contains a subpath, ensuring the correct path is preserved regardless of whether the base URL ends with a trailing slash. It also adds new tests to verify this behavior.
Bug Fixes and Improvements:
getHelmDownloadURLcorrectly handles base URLs with or without a trailing slash, preserving subpath segments and preventing incorrect URL resolution. (src/run.ts)Testing Enhancements:
getHelmDownloadURLpreserves subpath base URLs both with and without a trailing slash. (src/run.test.ts)Ensure downloadBaseURL ends with '/' before URL resolution so a subpath mirror (e.g. https://example/kubernetes/helm) is preserved instead of having its last path segment replaced. Fixes downloads for all subpath mirrors.