Skip to content

Users/v dharmarajv/getparticipant fix (#47570) - #47577

Draft
Vinothini Dharmaraj (v-dharmarajv) wants to merge 21 commits into
mainfrom
release/callautomation/ga7
Draft

Vinothini Dharmaraj (v-dharmarajv) wants to merge 21 commits into
mainfrom
release/callautomation/ga7

Conversation

@v-dharmarajv

Copy link
Copy Markdown
Member
  • ga7 changes

  • recording the tests

  • re-record tests

  • latest apispec latest

  • addressing the comments

  • addressing comments

  • fixing copilot suggestions

  • Added recordingUrl validator. (Added recordingUrl validator. #45906)

  • Added recordingUrl validator.

  • Updated code.

  • Added gov endpoint to recordingUrlValidator

  • Updated url.

  • addressing comments

  • fixing analyze build issue

  • fixing the getparticipant issue

  • fixing the live tests

  • update change log


Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

* ga7 changes

* recording the tests

* re-record tests

* latest apispec latest

* addressing the comments

* addressing comments

* fixing copilot suggestions

* Added recordingUrl validator. (#45906)

* Added recordingUrl validator.

* Updated code.

* Added gov endpoint to recordingUrlValidator

* Updated url.

* addressing comments

* fixing analyze build issue

* fixing the getparticipant issue

* fixing the live tests

* update change log

---------

Co-authored-by: v-durgeshsu <v-durgeshsu@microsoft.com>
@github-actions

Copy link
Copy Markdown
Contributor

Hi Vinothini Dharmaraj (@v-dharmarajv). Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions Bot added the no-recent-activity There has been no recent activity on this issue. label Aug 28, 2026
@github-actions github-actions Bot removed the no-recent-activity There has been no recent activity on this issue. label Sep 1, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor
[Pilot] PR Pipeline Failure Analysis

What failed

Build 6831805 (pipeline) — python - pullrequest and python - communication checks failed on two independent issues:

1. azure-communication-callautomation — live test playback failures (all 5 platforms x whl/sdist = 10 artifact files, ~48 unique tests each)
Platforms: macos311_b1, ubuntu2404_310_b1, ubuntu2404_310_coverage_b1, Ubuntu2404_313_b1, windows2022_312_b1.
Every failure is the same root cause: recorded test-proxy sessions no longer match the calls the tests actually make (e.g. test_e2e_callautomation_client.*, test_e2e_media_client.* and their async variants).

Relevant pipeline output
azure.core.exceptions.ResourceNotFoundError: Playback failure -- for help resolving, see https://aka.ms/azsdk/python/test-proxy/troubleshoot. Error details:
Unable to find a record for the request POST (sanitized/redacted)
Header differences:
    <Accept-Encoding> values differ, request <gzip, deflate>, record <gzip, deflate, zstd>
Body differences:
Remaining Entries:
0: (sanitized/redacted)
1: (sanitized/redacted)
2: (sanitized/redacted)
3: (sanitized/redacted)
4: (sanitized/redacted)

Same recording-mismatch pattern repeats for test_list_participants, test_get_participant, test_add_participant_then_cancel_request, test_create_VOIP_call_and_connect_call_then_hangup, test_start_recording_with_*, and all test_e2e_media_client play/streaming/transcription tests (sync + async). This is consistent across every OS/Python combination, so it is a single root cause (stale recordings), not per-platform bugs.

2. azure-communication-chat — mypy failure on samples
mypy :: sdk/communication/azure-communication-chat exited 1 (source code itself passed: "Verified mypy, no issues found"; only the sample check failed):

Relevant pipeline output
samples/user_credential_sample.py:50: error: Argument "token_refresher" to "CommunicationTokenCredential" has incompatible type "Callable[[], None]"; expected "Callable[[], AccessToken] | None"  [arg-type]
samples/chat_thread_client_sample.py:69: error: Argument 1 to "ChatClient" has incompatible type "str | None"; expected "str"  [arg-type]
samples/chat_thread_client_sample.py:71: error: Argument "identifier" to "ChatParticipant" has incompatible type "CommunicationUserIdentifier"; expected "CommunicationIdentifier"  [arg-type]
samples/chat_thread_client_sample.py:94: error: Name "chat_thread" is not defined  [name-defined]

The PR modifies azure-communication-chat's _chat_client.py, _chat_thread_client.py, _communication_identifier_serializer.py, _shared/policy.py, and _utils.py (shared identifier/policy code also used by callautomation), but does not touch the sample files — these mypy errors in samples/ are pre-existing/latent type issues exposed by the current mypy check and are within this PR's touched package, so they are addressable by a source/sample-side type fix.

Recommended next steps

  • Callautomation: this environment has no Azure DevOps/az live-test credentials, so recordings cannot be automatically re-generated here. Re-record the affected test_e2e_callautomation_client* and test_e2e_media_client* sessions locally while authenticated (az login) against the current API version, then commit the updated recordings.
  • Chat: fix the mypy sample errors — add proper types/Optional handling in samples/user_credential_sample.py and samples/chat_thread_client_sample.py (undefined chat_thread name, str | None vs str args, CommunicationIdentifier vs CommunicationUserIdentifier mismatch).
  • See https://aka.ms/ci-fix

Automated fix: Fix found, view and apply fix

Generated by Pipeline Analysis Next Steps · auto · 182.8 AIC · ⌖ 2.07 AIC · ⊞ 9.2K ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants