verify network api - #30123
Open
Qi Pan (Pan-Qi) wants to merge 1 commit into
Open
Conversation
Contributor
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new tooling scripts contain a parameter mismatch that breaks test-module.ps1, and the PR also checks in a large generated/modules/Az.Accounts payload that is likely unintended and has significant repo footprint implications.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates a Network SDK AutoRest configuration reference and adds a new Az.Astro AutoRest-based module scaffold (scripts, runtime helpers, and generated model types), along with an embedded local copy of Az.Accounts under generated/modules.
Changes:
- Updated Network Management SDK AutoRest commit reference and corrected generated XML docstrings for NIC IP configuration operations.
- Added
Az.Astromodule scaffolding, including build/run/test/pack scripts and a large set of generated runtime + model code. - Added a full packaged
Az.Accountspayload undersrc/Astro/Astro.Autorest/generated/modules(notable repo footprint increase).
File summaries
| File | Description |
|---|---|
| src/Network/Network.Management.Sdk/README.md | Updates AutoRest commit reference used for Network SDK generation. |
| src/Network/Network.Management.Sdk/Generated/NetworkInterfaceIPConfigurationsOperationsExtensions.cs | Docstring correction for ipConfigurationName parameter. |
| src/Network/Network.Management.Sdk/Generated/NetworkInterfaceIPConfigurationsOperations.cs | Docstring correction for ipConfigurationName parameter. |
| src/Network/Network.Management.Sdk/Generated/INetworkInterfaceIPConfigurationsOperations.cs | Docstring correction for ipConfigurationName parameter. |
| src/Astro/Astro.Autorest/tools/Resources/test/README.md | Adds template documentation for module test folder. |
| src/Astro/Astro.Autorest/tools/Resources/resources/README.md | Adds template documentation for non-packaged resource folder. |
| src/Astro/Astro.Autorest/tools/Resources/how-to.md | Adds development how-to for the Resources tooling area (currently references Az.Resources). |
| src/Astro/Astro.Autorest/tools/Resources/examples/README.md | Adds template documentation for example stubs folder. |
| src/Astro/Astro.Autorest/tools/Resources/docs/README.md | Adds template documentation for generated docs folder. |
| src/Astro/Astro.Autorest/tools/Resources/.gitattributes | Adds default text normalization for the Resources tooling area. |
| src/Astro/Astro.Autorest/test-module.ps1 | Adds module test runner script (Pester + playback/record/live support). |
| src/Astro/Astro.Autorest/run-module.ps1 | Adds isolated module runner script (optionally launches VS Code attach config). |
| src/Astro/Astro.Autorest/pack-module.ps1 | Adds packaging script wrapper around dotnet pack. |
| src/Astro/Astro.Autorest/internal/README.md | Documents purpose/constraints of internal-only cmdlets folder. |
| src/Astro/Astro.Autorest/internal/Get-AzAstroOperation.ps1 | Adds generated internal proxy cmdlet for listing provider operations. |
| src/Astro/Astro.Autorest/internal/Az.Astro.internal.psm1 | Adds internal module loader/export logic for hidden cmdlets. |
| src/Astro/Astro.Autorest/generated/runtime/UndeclaredResponseException.cs | Adds runtime REST exception types for undeclared responses. |
| src/Astro/Astro.Autorest/generated/runtime/SerializationMode.cs | Adds runtime serialization mode flags enum. |
| src/Astro/Astro.Autorest/generated/runtime/Serialization/SerializationOptions.cs | Adds JSON serialization options used by runtime serializers. |
| src/Astro/Astro.Autorest/generated/runtime/Serialization/PropertyTransformation.cs | Adds per-property transformation support for JSON serialization. |
| src/Astro/Astro.Autorest/generated/runtime/Response.cs | Adds runtime Response / Response<T> wrappers. |
| src/Astro/Astro.Autorest/generated/runtime/Parser/TokenReader.cs | Adds JSON token reader helper for parser pipeline. |
| src/Astro/Astro.Autorest/generated/runtime/Parser/Readers/SourceReader.cs | Adds streaming source reader with location tracking. |
| src/Astro/Astro.Autorest/generated/runtime/Parser/Location.cs | Adds SourceLocation struct used by JSON parser. |
| src/Astro/Astro.Autorest/generated/runtime/Parser/JsonToken.cs | Adds token kinds and token structure for JSON parsing. |
| src/Astro/Astro.Autorest/generated/runtime/Parser/Exceptions/ParseException.cs | Adds parser exception type with location support. |
| src/Astro/Astro.Autorest/generated/runtime/Nodes/XNull.cs | Adds singleton JSON null node. |
| src/Astro/Astro.Autorest/generated/runtime/Nodes/XBinary.cs | Adds JSON binary node with base64 support. |
| src/Astro/Astro.Autorest/generated/runtime/Nodes/JsonString.cs | Adds JSON string node type. |
| src/Astro/Astro.Autorest/generated/runtime/Nodes/JsonNumber.cs | Adds JSON number node type and numeric casts. |
| src/Astro/Astro.Autorest/generated/runtime/Nodes/JsonBoolean.cs | Adds JSON boolean node type. |
| src/Astro/Astro.Autorest/generated/runtime/Nodes/Collections/XSet.cs | Adds set-backed JSON array representation. |
| src/Astro/Astro.Autorest/generated/runtime/Nodes/Collections/XNodeArray.cs | Adds list-backed JSON node array implementation. |
| src/Astro/Astro.Autorest/generated/runtime/Nodes/Collections/XList.cs | Adds list-backed JSON array wrapper for typed lists. |
| src/Astro/Astro.Autorest/generated/runtime/Nodes/Collections/XImmutableArray.cs | Adds array-backed JSON array wrapper for typed arrays. |
| src/Astro/Astro.Autorest/generated/runtime/Nodes/Collections/JsonArray.cs | Adds JSON array base type + factory helpers. |
| src/Astro/Astro.Autorest/generated/runtime/Models/JsonModelCache.cs | Adds reflection model cache for JSON model binding. |
| src/Astro/Astro.Autorest/generated/runtime/Models/JsonModel.cs | Adds reflection-driven JSON member mapping. |
| src/Astro/Astro.Autorest/generated/runtime/Models/JsonMember.cs | Adds reflection wrapper for field/property serialization metadata. |
| src/Astro/Astro.Autorest/generated/runtime/Method.cs | Adds HTTP method constants used by runtime pipeline. |
| src/Astro/Astro.Autorest/generated/runtime/JsonType.cs | Adds JSON type enum used across runtime nodes. |
| src/Astro/Astro.Autorest/generated/runtime/InputHandler.cs | Adds cmdlet input handler base type. |
| src/Astro/Astro.Autorest/generated/runtime/InfoAttribute.cs | Adds runtime info/metadata attributes used for models. |
| src/Astro/Astro.Autorest/generated/runtime/IHeaderSerializable.cs | Adds interface for response-header deserialization. |
| src/Astro/Astro.Autorest/generated/runtime/IAssociativeArray.cs | Adds associative-array abstraction for PowerShell formatting behavior. |
| src/Astro/Astro.Autorest/generated/runtime/HttpPipelineMocking.ps1 | Adds test mocking pipeline overrides for Pester scenarios. |
| src/Astro/Astro.Autorest/generated/runtime/HttpPipeline.cs | Extends pipeline to accept delegate-based pipeline steps. |
| src/Astro/Astro.Autorest/generated/runtime/Helpers/XHelper.cs | Adds JSON node creation helpers based on type codes. |
| src/Astro/Astro.Autorest/generated/runtime/Helpers/TypeDetails.cs | Adds reflection/type analysis helpers for converter selection. |
| src/Astro/Astro.Autorest/generated/runtime/Helpers/Seperator.cs | Adds helper constants used by ISO/date parsing code. |
| src/Astro/Astro.Autorest/generated/runtime/Helpers/Extensions/TypeExtensions.cs | Adds reflection helper extensions for open generic interfaces. |
| src/Astro/Astro.Autorest/generated/runtime/Helpers/Extensions/StringBuilderExtensions.cs | Adds small helper for StringBuilder extraction/reset. |
| src/Astro/Astro.Autorest/generated/runtime/Extensions.cs | Adds runtime extension helpers (headers, sync context suppression, etc.). |
| src/Astro/Astro.Autorest/generated/runtime/EventsExtensions.cs | Adds cmdlet event name constants. |
| src/Astro/Astro.Autorest/generated/runtime/Events.cs | Adds runtime event name constants. |
| src/Astro/Astro.Autorest/generated/runtime/EventDataExtensions.cs | Adds PowerShell type converter for cross-module event data. |
| src/Astro/Astro.Autorest/generated/runtime/EventData.cs | Adds base EventData fields used for runtime signaling. |
| src/Astro/Astro.Autorest/generated/runtime/DictionaryExtensions.cs | Adds conversion helper from hashtable to dictionary. |
| src/Astro/Astro.Autorest/generated/runtime/delegates.cs | Adds delegates used by the pipeline/event infrastructure. |
| src/Astro/Astro.Autorest/generated/runtime/Debugging.cs | Adds debugger attach helper. |
| src/Astro/Astro.Autorest/generated/runtime/Customizations/XNodeArray.cs | Adds safer creation/add patterns for XNodeArray. |
| src/Astro/Astro.Autorest/generated/runtime/Customizations/JsonString.cs | Adds JsonString conversions for date/time and chars. |
| src/Astro/Astro.Autorest/generated/runtime/Customizations/JsonNumber.cs | Adds JsonNumber conversions + ToValue override. |
| src/Astro/Astro.Autorest/generated/runtime/Customizations/JsonNode.cs | Adds ToValue() virtual for runtime node value extraction. |
| src/Astro/Astro.Autorest/generated/runtime/Customizations/JsonBoolean.cs | Adds JsonBoolean ToValue() override + nullable create helper. |
| src/Astro/Astro.Autorest/generated/runtime/Customizations/JsonArray.cs | Adds JsonArray ToValue() override. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/StringLikeConverter.cs | Adds string-like converter with reflection Parse support. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/JsonConverterFactory.cs | Adds converter registry + lookup APIs. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/JsonConverterAttribute.cs | Adds attribute to attach custom converters to types. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/JsonConverter.cs | Adds typed converter base type. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/UriConverter.cs | Adds URI converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/UInt64Converter.cs | Adds UInt64 converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/UInt32Converter.cs | Adds UInt32 converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/UInt16Converter.cs | Adds UInt16 converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/TimeSpanConverter.cs | Adds TimeSpan converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/StringConverter.cs | Adds string converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/SingleConverter.cs | Adds float converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/JsonObjectConverter.cs | Adds JsonObject converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/JsonArrayConverter.cs | Adds JsonArray converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/Int64Converter.cs | Adds Int64 converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/Int32Converter.cs | Adds Int32 converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/Int16Converter.cs | Adds Int16 converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/HashSet'1Converter.cs | Adds HashSet converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/GuidConverter.cs | Adds Guid converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/EnumConverter.cs | Adds enum converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/DoubleConverter.cs | Adds double converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/DecimalConverter.cs | Adds decimal converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/DateTimeOffsetConverter.cs | Adds DateTimeOffset converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/DateTimeConverter.cs | Adds DateTime converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/BooleanConverter.cs | Adds bool converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/Instances/BinaryConverter.cs | Adds byte[] converter. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/IJsonConverter.cs | Adds non-generic converter interface. |
| src/Astro/Astro.Autorest/generated/runtime/Conversions/ConversionException.cs | Adds conversion exception type. |
| src/Astro/Astro.Autorest/generated/runtime/Context.cs | Adds runtime IContext interface for cmdlet customization. |
| src/Astro/Astro.Autorest/generated/runtime/CmdInfoHandler.cs | Adds pipeline step that stamps cmdlet invocation headers. |
| src/Astro/Astro.Autorest/generated/runtime/BuildTime/XmlExtensions.cs | Adds build-time XML serialization helper. |
| src/Astro/Astro.Autorest/generated/runtime/BuildTime/StringExtensions.cs | Adds build-time string helpers. |
| src/Astro/Astro.Autorest/generated/runtime/BuildTime/PsAttributes.cs | Adds build-time PowerShell attribute types. |
| src/Astro/Astro.Autorest/generated/runtime/BuildTime/Models/PsFormatTypes.cs | Adds build-time PS1XML model types. |
| src/Astro/Astro.Autorest/generated/runtime/BuildTime/CollectionExtensions.cs | Adds build-time collection helpers (incl. DistinctBy). |
| src/Astro/Astro.Autorest/generated/runtime/BuildTime/Cmdlets/GetScriptCmdlet.cs | Adds build-time cmdlet to enumerate script cmdlets. |
| src/Astro/Astro.Autorest/generated/runtime/BuildTime/Cmdlets/GetModuleGuid.cs | Adds build-time cmdlet to read module GUID from psd1. |
| src/Astro/Astro.Autorest/generated/runtime/BuildTime/Cmdlets/GetCommonParameter.cs | Adds build-time cmdlet for extracting common parameters from bound params. |
| src/Astro/Astro.Autorest/generated/runtime/BuildTime/Cmdlets/ExportHelpMarkdown.cs | Adds build-time cmdlet to render help markdown. |
| src/Astro/Astro.Autorest/generated/runtime/BuildTime/Cmdlets/ExportFormatPs1xml.cs | Adds build-time cmdlet to generate formatting PS1XML. |
| src/Astro/Astro.Autorest/generated/runtime/BuildTime/Cmdlets/ExportExampleStub.cs | Adds build-time cmdlet to generate example markdown stubs. |
| src/Astro/Astro.Autorest/generated/runtime/BuildTime/Cmdlets/ExportCmdletSurface.cs | Adds build-time cmdlet to export cmdlet surface inventory. |
| src/Astro/Astro.Autorest/generated/runtime/Attributes/PSArgumentCompleterAttribute.cs | Adds custom argument completer attribute helper. |
| src/Astro/Astro.Autorest/generated/runtime/Attributes/ExternalDocsAttribute.cs | Adds external docs attribute for model metadata. |
| src/Astro/Astro.Autorest/generated/modules/Az.Accounts/2.13.1/package/services/metadata/core-properties/f9ac9c2e40914e78a646a7b0b997403b.psmdcp | Adds Az.Accounts package metadata artifact under generated modules. |
| src/Astro/Astro.Autorest/generated/modules/Az.Accounts/2.13.1/en-US/about_az.help.txt | Adds Az.Accounts help text artifact under generated modules. |
| src/Astro/Astro.Autorest/generated/modules/Az.Accounts/2.13.1/Az.Accounts.nuspec | Adds Az.Accounts nuspec artifact under generated modules. |
| src/Astro/Astro.Autorest/generated/modules/Az.Accounts/2.13.1/[Content_Types].xml | Adds NuGet package content types artifact under generated modules. |
| src/Astro/Astro.Autorest/generated/modules/Az.Accounts/2.13.1/_rels/.rels | Adds NuGet package relationship artifact under generated modules. |
| src/Astro/Astro.Autorest/generated/api/Models/UserAssignedIdentity.cs | Adds generated model type(s) for identities. |
| src/Astro/Astro.Autorest/generated/api/Models/UserAssignedIdentities.dictionary.cs | Adds generated associative-array backing for identities dictionary. |
| src/Astro/Astro.Autorest/generated/api/Models/UserAssignedIdentities.cs | Adds generated identities dictionary wrapper type. |
| src/Astro/Astro.Autorest/generated/api/Models/TrackedResourceTags.dictionary.cs | Adds generated associative-array backing for tags dictionary. |
| src/Astro/Astro.Autorest/generated/api/Models/TrackedResourceTags.cs | Adds generated tags dictionary wrapper type. |
| src/Astro/Astro.Autorest/generated/api/Models/OrganizationResourceUpdateTags.dictionary.cs | Adds generated associative-array backing for update tags dictionary. |
| src/Astro/Astro.Autorest/generated/api/Models/OrganizationResourceUpdateTags.cs | Adds generated update tags dictionary wrapper type. |
| src/Astro/Astro.Autorest/generated/api/Models/OrganizationResourceListResult.cs | Adds generated list result model with paging. |
| src/Astro/Astro.Autorest/generated/api/Models/OperationListResult.cs | Adds generated operations list result model. |
| src/Astro/Astro.Autorest/generated/api/Models/ErrorAdditionalInfo.cs | Adds generated error additional info model. |
| src/Astro/Astro.Autorest/generated/api/Models/AstroIdentity.cs | Adds generated resource identity model for Astro. |
| src/Astro/Astro.Autorest/generated/api/Models/Any.cs | Adds generated “Any” model type. |
| src/Astro/Astro.Autorest/generate-help.ps1 | Adds script to generate markdown help into docs/. |
| src/Astro/Astro.Autorest/exports/README.md | Documents generated exports folder structure and usage. |
| src/Astro/Astro.Autorest/export-surface.ps1 | Adds script to export cmdlet/model surface markdown into resources folder. |
| src/Astro/Astro.Autorest/check-dependencies.ps1 | Adds script for downloading/building dependent modules for running/tests. |
| src/Astro/Astro.Autorest/Az.Astro.psd1 | Adds Astro module manifest. |
| src/Astro/Astro.Autorest/Az.Astro.nuspec | Adds nuspec for packaging Astro module. |
| src/Astro/Astro.Autorest/Az.Astro.csproj | Adds Az.Astro.private SDK-style project file. |
Review details
- Files reviewed: 17/378 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # Code generated by Microsoft (R) AutoRest Code Generator.Changes may cause incorrect behavior and will be lost if the code | ||
| # is regenerated. | ||
| # ---------------------------------------------------------------------------------- | ||
| param([switch]$NotIsolated, [switch]$Accounts, [switch]$Pester, [switch]$Resources) |
Comment on lines
+25
to
+28
| $dll = Join-Path $PSScriptRoot 'bin\Az.Astro.private.dll' | ||
| if(-not (Test-Path $dll)) { | ||
| Write-Error "Unable to find output assembly in '$binFolder'." | ||
| } |
| $baseName = $PSScriptRoot.BaseName | ||
| $requireResourceModule = (($baseName -ne "Resources") -and ($Record.IsPresent -or $Live.IsPresent)) | ||
| . (Join-Path $PSScriptRoot 'check-dependencies.ps1') -NotIsolated -Accounts:$false -Pester -Resources:$requireResourceModule -RegenerateSupportModule:$RegenerateSupportModule | ||
| . ("$PSScriptRoot\test\utils.ps1") |
Comment on lines
+1
to
+5
| # How-To | ||
| This document describes how to develop for `Az.Resources`. | ||
|
|
||
| ## Building `Az.Resources` | ||
| To build, run the `build-module.ps1` at the root of the module directory. This will generate the proxy script cmdlets that are the cmdlets being exported by this module. After the build completes, the proxy script cmdlets will be output to the `exports` folder. To read more about the proxy script cmdlets, look at the [README.md](exports/README.md) in the `exports` folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.