-
Notifications
You must be signed in to change notification settings - Fork 115
fix: early OpenTelemetry context propagation in invocation #1882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hallvictoria
wants to merge
14
commits into
dev
Choose a base branch
from
hallvictoria/otel-context-prop
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
33124bb
Move otel context propagation
hallvictoria fe041e5
Merge branch 'dev' into hallvictoria/otel-context-prop
hallvictoria 035c1be
Merge branch 'dev' of https://github.com/Azure/azure-functions-python…
hallvictoria e7f1c52
Merge branch 'dev' into hallvictoria/otel-context-prop
hallvictoria 91aa85c
minor updates
hallvictoria 725a3bd
Merge branch 'hallvictoria/otel-context-prop' of https://github.com/A…
hallvictoria aa2b055
Merge branch 'dev' into hallvictoria/otel-context-prop
hallvictoria 7016913
add tests
hallvictoria f8e66a7
remove double call for sync functions
hallvictoria 5e68f0a
lint
hallvictoria daab86f
Merge branch 'dev' into hallvictoria/otel-context-prop
hallvictoria 98e8cbe
remove unnecessary imports
hallvictoria b08148d
remove extra call
hallvictoria 9bba764
restore
hallvictoria File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import concurrent.futures | ||
| import threading | ||
| import unittest | ||
| from unittest.mock import MagicMock | ||
|
|
||
| from azure_functions_runtime_v1.utils.executor import ( | ||
| invocation_id_cv, | ||
| run_sync_func, | ||
| ) | ||
|
|
||
|
|
||
| class TestSyncInvocationContext(unittest.TestCase): | ||
|
|
||
| def setUp(self): | ||
| self.context = MagicMock() | ||
| self.context.thread_local_storage = threading.local() | ||
| self.executor = concurrent.futures.ThreadPoolExecutor(max_workers=1) | ||
|
|
||
| def tearDown(self): | ||
| self.executor.shutdown() | ||
|
|
||
| def _get_current_invocation_ids(self): | ||
| return (self.context.thread_local_storage.invocation_id, | ||
| invocation_id_cv.get()) | ||
|
|
||
| def test_invocation_id_cleared_after_success(self): | ||
| observed_invocation_ids = [] | ||
|
|
||
| def invoke(): | ||
| observed_invocation_ids.append(self._get_current_invocation_ids()) | ||
|
|
||
| self.executor.submit( | ||
| run_sync_func, | ||
| 'test-invocation', self.context, invoke, {}).result() | ||
|
|
||
| remaining_invocation_ids = self.executor.submit( | ||
| self._get_current_invocation_ids).result() | ||
| self.assertEqual( | ||
| observed_invocation_ids, | ||
| [('test-invocation', 'test-invocation')]) | ||
| self.assertEqual(remaining_invocation_ids, (None, None)) | ||
|
|
||
| def test_invocation_id_cleared_after_exception(self): | ||
| def invoke(): | ||
| self.assertEqual( | ||
| self._get_current_invocation_ids(), | ||
| ('test-invocation', 'test-invocation')) | ||
| raise RuntimeError('test error') | ||
|
|
||
| with self.assertRaisesRegex(RuntimeError, 'test error'): | ||
| self.executor.submit( | ||
| run_sync_func, | ||
| 'test-invocation', self.context, invoke, {}).result() | ||
|
|
||
| remaining_invocation_ids = self.executor.submit( | ||
| self._get_current_invocation_ids).result() | ||
| self.assertEqual(remaining_invocation_ids, (None, None)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.