[Core] update azurebleucloud endpoints and suffixes - #34049
Open
alexkm-bleucloud wants to merge 7 commits into
Open
[Core] update azurebleucloud endpoints and suffixes#34049alexkm-bleucloud wants to merge 7 commits into
alexkm-bleucloud wants to merge 7 commits into
Conversation
Adds several new resource IDs (App Insights, Log Analytics, Synapse, attestation, Active Directory Data Lake, ADL suffixes), fixes the missing leading dot on attestation_endpoint, normalizes trailing slashes on several endpoint URLs, and updates vm_image_alias_doc to match the current metadata source. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Individual PRs don't touch HISTORY.rst in this repo -- it's aggregated
in bulk by the automated {Release} Upgrade commit, not by contributors.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
Yu Chen (jsntcy),
ZelinWang (wangzelin007) and
Yong Zhang (yonzhan)
September 9, 2026 09:36
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution alexkm-bleucloud! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
added
Auto-Assign
Collaborator
|
Cloud |
alexkm-bleucloud
commented
Sep 9, 2026
alexkm-bleucloud
left a comment
alexkm-bleucloud
left a comment
Author
There was a problem hiding this comment.
@microsoft-github-policy-service agree
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new trailing slash on endpoints.portal can produce double-slash portal deep links in existing callers that append '/#resource/...' to the portal base URL.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the hardcoded AzureBleuCloud definition in azure-cli-core so az cloud set -n AzureBleuCloud provides a more complete and corrected set of resource endpoints and DNS suffixes for Azure CLI to use.
Changes:
- Added previously-unset AzureBleuCloud endpoints (Data Lake, App Insights, Log Analytics, Synapse, Attestation).
- Added Data Lake-related suffixes and corrected
attestation_endpointsuffix formatting. - Updated
vm_image_alias_docURL and normalized several endpoint trailing slashes for consistency.
File summaries
| File | Description |
|---|---|
src/azure-cli-core/azure/cli/core/cloud.py |
Extends and corrects the hardcoded AzureBleuCloud endpoints/suffixes used by Azure CLI cloud selection. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
@microsoft-github-policy-service agree |
Review feedback: several callers build portal deep links by concatenating endpoints.portal + '/#resource/...' (e.g. src/azure-cli/azure/cli/command_modules/acs/custom.py:339), which produced a double slash with the trailing '/' this endpoint had. Every other hardcoded cloud's portal endpoint has no trailing slash; this restores that convention. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…dpoints' into feature/update-azurebleucloud-endpoints
Same class of bug as the portal fix: src/azure-cli/azure/cli/command_modules/profile/_validators.py:19
builds the OIDC discovery URL via
'{}/{}/v2.0/.well-known/openid-configuration'.format(active_directory_endpoint, tenant),
which double-slashes when the endpoint already ends in '/'. This
breaks az login --tenant <domain-name> (non-GUID tenant) against
AzureBleuCloud. Every other hardcoded cloud's active_directory
endpoint has no trailing slash; this restores that convention.
The MSAL-facing path (_create_identity_instance -> Identity ->
PublicClientApplication) normalizes trailing slashes internally and
is unaffected either way.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
alexkm-bleucloud
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az cloud set -n AzureBleuCloud
Description
Updates the hardcoded AzureBleuCloud cloud definition in src/azure-cli-core/azure/cli/core/cloud.py to add several resource endpoints that weren't previously configured, and correct a couple of existing values.
New endpoints/suffixes added (previously unset):
Corrected values:
Also normalized trailing slashes on
resource_managerandmicrosoft_graph_resource_idfor consistency with this cloud's other endpoint values.The cloud name (
AzureBleuCloud) is unchanged —az cloud set -n AzureBleuCloudcontinues to work as before.Review feedback addressed :
endpoints.portalno longer has a trailing slash as per Copilot review feedbackendpoints.active_directoryno longer has a trailing slash either, for the same reason (induced a double-slash concat bug downstream)Testing Guide
run az cloud set -n AzureBleuCloud
No impact on unit tests. Ran test_cloud.py locally successfully.
History Notes
[Cloud]
az cloud set -n AzureBleuCloud: Added unset previously unset endpointsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.