[AKS] Synchronize monitoring profiles and repair live scenarios - #34047
Draft
FumingZhang wants to merge 2 commits into
Draft
[AKS] Synchronize monitoring profiles and repair live scenarios#34047FumingZhang wants to merge 2 commits into
FumingZhang wants to merge 2 commits into
Conversation
Keep canonical Container Insights settings aligned with legacy monitoring addon values in SDK PUT payloads. Resume metrics setup after retried creates, wait before dependent assertions, and honor live region and capacity constraints without weakening failure checks. Validation: 91 targeted tests and 27 subtests passed with repository-pinned SDK 41.6.0; 283 live scenarios collected. Original-source regressions failed before the fixes. No AKS RP changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
microsoft-github-policy-service
Bot
requested review from
elvazhu521,
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
September 9, 2026 06:36
Collaborator
|
AKS |
Real live validation confirms enabled=false while Azure retains workspace and authentication metadata. Keep the persisted disabled-state check rather than requiring the entire addon config to disappear. Validation: affected test_aks_create_default_service_with_monitoring_addon_msi passed end-to-end in LIVE mode (674 seconds), including re-enable. No unit or mocked run substitutes for this result. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
az aks enable-addons,az aks disable-addons,az aks updateDescription
Follow-up to #34037 for failures observed after the previous runner fixes:
azureMonitorProfile.containerInsightsvalues with legacy monitoring addon settings in outgoing SDK requests.Testing Guide
AZURE_TEST_RUN_LIVE=trueandAZURE_CLI_TEST_RETRY_PROVISIONING_CHECK=true; cassette writing was disabled. No unit/mock result is counted as a live pass.enabled=falsecheck and allowing retained metadata, its full live rerun passed in 674 seconds. This correction is published ind987836f78.test_aks_automatic_skuremains blocked by Microsoft Graph Conditional Access; it is not a pass.InvalidAssociation. That workspace-mapping experiment is deliberately NOT committed or included in this PR. ACNS's separate westus2 live pass does not validate the EUAP variant.History Notes
[AKS]
az aks update: Fix enabling and disabling container network logs when the cluster returns an Azure Monitor Container Insights profile[AKS]
az aks enable-addons,az aks disable-addons: Fix monitoring state and workspace updates when the cluster returns an Azure Monitor Container Insights profileThis checklist is used to make sure that common guidelines for a pull request are followed.