NetworkCloud v5.1.1 update to remove 'create' and 'delete' from 'kubernetesversion' command group for non-support. - #10289
Conversation
…rnetesversion' command group for non-support.
|
Hi idanielsteven, |
|
Thank you for your contribution idanielsteven! We will review the pull request and get back to you soon. |
|
Breaking changes are false-positive. These commands are not supported by the current API backend. These should not have been included, and they don't work when executed. |
There was a problem hiding this comment.
🟡 Changes recommended
It introduces a breaking CLI change under a patch version bump and leaves kubernetesversion update help text referencing the now-removed create command.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the networkcloud Azure CLI extension to v5.1.1 and removes unsupported kubernetesversion create/delete commands that were accidentally exposed, aligning the CLI surface area with API support.
Changes:
- Bump extension version to 5.1.1 and add a release note describing the command removals.
- Remove AAZ-generated
networkcloud kubernetesversion create/deletecommand implementations and stop importing them. - Update the kubernetesversion scenario test to stop calling create/delete.
File summaries
| File | Description |
|---|---|
| src/networkcloud/setup.py | Bumps extension version to 5.1.1. |
| src/networkcloud/HISTORY.rst | Adds 5.1.1 changelog entry documenting removal of kubernetesversion create/delete. |
| src/networkcloud/azext_networkcloud/tests/latest/test_kubernetesversion.py | Removes create/delete steps from the kubernetesversion scenario. |
| src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/kubernetesversion/_delete.py | Removes AAZ-generated kubernetesversion delete command implementation. |
| src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/kubernetesversion/_create.py | Removes AAZ-generated kubernetesversion create command implementation. |
| src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/kubernetesversion/init.py | Stops importing create/delete command modules so they are no longer registered/exported. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…rnetesversion' command group for non-support.
|
NetworkCloud |
|
[Release] Update index.json for extension [ networkcloud-5.1.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=179452696&view=results |
🤖 PR Validation — ❌ Action needed
❌Azure CLI Extensions Breaking Change Test
NetworkCloud v5.1.1 update to remove 'create' and 'delete' from 'kubernetesversion' command group for non-support.
These are not supported by the API and were provided by accident.
aaz: Azure/aaz#1080
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.