Skip to content

NetworkCloud v5.1.1 update to remove 'create' and 'delete' from 'kubernetesversion' command group for non-support. - #10289

Merged
Ethan Yang (necusjz) merged 8 commits into
Azure:mainfrom
ejiadedeji:main
Sep 3, 2026
Merged

NetworkCloud v5.1.1 update to remove 'create' and 'delete' from 'kubernetesversion' command group for non-support.#10289
Ethan Yang (necusjz) merged 8 commits into
Azure:mainfrom
ejiadedeji:main

Conversation

@idanielsteven

@idanielsteven idanielsteven commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🤖 PR Validation — ❌ Action needed

Breaking Changes
❌ 1
❌Azure CLI Extensions Breaking Change Test
❌networkcloud
rule cmd_name rule_message suggest_message
1002 - CmdRemove networkcloud kubernetesversion create cmd networkcloud kubernetesversion create removed please confirm cmd networkcloud kubernetesversion create removed
1002 - CmdRemove networkcloud kubernetesversion delete cmd networkcloud kubernetesversion delete removed please confirm cmd networkcloud kubernetesversion delete removed

NetworkCloud v5.1.1 update to remove 'create' and 'delete' from 'kubernetesversion' command group for non-support.

These are not supported by the API and were provided by accident.

aaz: Azure/aaz#1080


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi idanielsteven,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in pyproject.toml (or setup.py, if the extension has not migrated yet) as well.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 2, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Thank you for your contribution idanielsteven! We will review the pull request and get back to you soon.

@idanielsteven

Copy link
Copy Markdown
Contributor Author

Breaking changes are false-positive. These commands are not supported by the current API backend. These should not have been included, and they don't work when executed.

@idanielsteven
idanielsteven marked this pull request as ready for review September 2, 2026 19:37
Copilot AI lite review requested due to automatic review settings September 2, 2026 19:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

It introduces a breaking CLI change under a patch version bump and leaves kubernetesversion update help text referencing the now-removed create command.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates the networkcloud Azure CLI extension to v5.1.1 and removes unsupported kubernetesversion create/delete commands that were accidentally exposed, aligning the CLI surface area with API support.

Changes:

  • Bump extension version to 5.1.1 and add a release note describing the command removals.
  • Remove AAZ-generated networkcloud kubernetesversion create / delete command implementations and stop importing them.
  • Update the kubernetesversion scenario test to stop calling create/delete.
File summaries
File Description
src/networkcloud/setup.py Bumps extension version to 5.1.1.
src/networkcloud/HISTORY.rst Adds 5.1.1 changelog entry documenting removal of kubernetesversion create/delete.
src/networkcloud/azext_networkcloud/tests/latest/test_kubernetesversion.py Removes create/delete steps from the kubernetesversion scenario.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/kubernetesversion/_delete.py Removes AAZ-generated kubernetesversion delete command implementation.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/kubernetesversion/_create.py Removes AAZ-generated kubernetesversion create command implementation.
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/kubernetesversion/init.py Stops importing create/delete command modules so they are no longer registered/exported.
Review details
  • Files reviewed: 6/6 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/networkcloud/setup.py
…rnetesversion' command group for non-support.
@yonzhan

Copy link
Copy Markdown
Collaborator

NetworkCloud

@necusjz
Ethan Yang (necusjz) merged commit e30f9df into Azure:main Sep 3, 2026
24 checks passed
@azclibot

Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ networkcloud-5.1.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=179452696&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants