Repository navigation
impact: a TypeScript object-literal key survives the bound-field-access line rule - #1818
Merged
swapnilpaliwal-sd merged 1 commit intoSep 30, 2026
Conversation
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 30, 2026 08:37
…same-named field on its line
What was wrong
- `const meta: EventMeta = { eventId: options.eventId ?? … }` stopped listing its function
under `impact EventMeta.eventId`. The per-line rule that drops a name match on a line where
the engine bound a field access (to this field or to another field of that name) drops every
ref of that name on the line. Refs carry no column, and TypeScript stored the literal key
`eventId` as a plain UNKNOWN identifier, so the key went with the bound `options.eventId`
read of PublishOptions.eventId. field_access has no row for an object literal key, so
nothing else reported the write.
The change
- axiomcode-index: a TypeScript expression in the OBJECT_PROPERTY_KEY role is stored with
entity kind OBJECT_PROPERTY_KEY instead of UNKNOWN.
- dl/impact.dl: fref keeps a ref of that kind past fa_line. A bound access on another line,
and the bound access itself, are still not this field's readers.
- IMPACT_VERSION 56.
tests/cases/typescript/object-key-beside-a-bound-access: red before, green after, with two
controls (a line that only reads the other type's field stays out; the bound read stays the
other field's resolved reader). tests/run.py --lang typescript: 204 of 204.
Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
force-pushed
the
fix/ts-object-key-not-a-bound-access
branch
from
September 30, 2026 08:51
72a59b3 to
a2c47e2
Compare
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A probe that passed before now failed.
impact EventMeta.eventIdlost its writer on the line{ eventId: options.eventId }.Cause. The per-line rule
fa_lineindl/impact.dl, added for C# field access, drops every name match on a line where the engine bound a field access. On that line it bindsoptions.eventIdtoPublishOptions.eventId. The object-literal keyeventId, which writesEventMeta.eventId, was stored as the same kind of reference with no column to tell the two apart, so it was dropped as well.Fix.
axiomcode-indextags TypeScript object-literal keysOBJECT_PROPERTY_KEY, and thefrefrule keeps them pastfa_line.IMPACT_VERSIONgoes to 56. The C# rule's intent still holds: a read of the same name on another line stays excluded.Tests
tests/cases/typescript/object-key-beside-a-bound-access, with two controls: red before the fix, green after.tests/run.py --lang typescript: 204/204. The base passes 201/201; the three extra checks are the new case.bus-meta-event-id-causationis the only probe that changed.