sync trunk - #4
Merged
Merged
Conversation
## Summary Mark the SQLite plugin as **tested up to WordPress 7.0**, and: - Update the WordPress test environment from 6.7.2 to 7.0.1. - Normalize non-padded temporal literals used by WordPress 6.8 and later. - Remove WordPress test failures that now pass. - Add exclusions for tests that now fail. These will be fixed in a follow-up PR. ## Why Make sure the SQLite plugin is tested up to WordPress 7.0. Normalize date literals generated by WordPress 6.8 and later. WordPress 6.8 changed `get_calendar()` to generate date bounds with integer month components, producing literals such as `2026-2-01`. MySQL interprets these values as dates, while SQLite compares temporal strings lexically. Normalizing the components preserves correct calendar queries. ## Verification CI passing with tests updated to use WordPress 7.0.
## Summary Use the PDO-compatible `WP_MySQL_On_SQLite` class directly in both the WordPress plugin and MySQL proxy, while retaining `WP_SQLite_Driver` temporarily for backward compatibility. This includes: - Rename `WP_PDO_MySQL_On_SQLite` to `WP_MySQL_On_SQLite` and align implementation, test, tooling, and CI. - Adapt legacy SQL behavior tests and production consumers to the `PDOStatement` query API. This should be reviewed and merged together with Automattic/wp-cli-sqlite-command#33. ## Motivation Using the PDO-compatible driver directly makes it the primary public entry point with a clear, PDO-defined API. The legacy `WP_SQLite_Driver` constructor and result API remain available only as a temporary backward-compatibility layer. ## Developer impact The `WP_SQLite_Driver` API remains available for backward compatibility, but new consumers should construct `WP_MySQL_On_SQLite` with its DSN and options, and consume `query()` results as `PDOStatement` objects. Consumers using `WP_PDO_MySQL_On_SQLite` must update the class name to `WP_MySQL_On_SQLite`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.