feat(plugins): add portable plugin lockfile - #2976
Merged
Merged
Conversation
artrixdotdev
marked this pull request as draft
August 1, 2026 06:58
artrixdotdev
marked this pull request as ready for review
August 1, 2026 07:00
Purian23
requested changes
Aug 5, 2026
Purian23
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR!
The structure, tests, and docs look good.
Couple of items to hit:
1. Shared monorepo cleanup shouldCleanupRepo now only trusts the lockfile. If a sibling is still on disk but missing from the lock, uninstall can wipe the shared .repos. Please also check remaining installs (e.g. .meta) and add a regression test.
2. Update rollback when recordInstalledPlugin fails after pull, don’t ignore CheckoutRevision errors; surface a failed rollback so HEAD and the lockfile can’t diverge silently.
That should put us in good shape, thanks again!
bbedward
force-pushed
the
feat/plugin-lockfile
branch
from
August 7, 2026 14:45
ab950dd to
b884653
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a portable
~/.config/DankMaterialShell/plugins.lock.jsonthat stays synchronized with managed plugin installs, updates, and removals.dms plugins lockanddms plugins restore [lockfile], with optional--pruneType of change
Related issues
None.
Screenshots / video
Not applicable; this is a CLI and backend change.
Checklist
I18n.tr()with translator context, reusing existing terms where possible (no QML strings added)make fmt, added/updated tests,make testpasses, andgo mod tidyis clean