test: restore callback metadata contract - #2346
Merged
Merged
Conversation
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause and contract decision
d4a734f8intentionally addedcontentLength,serviceWorkerAllowed, andbodyRewrittento the typed bounded request trace for packaged-worker diagnostics.b86524a0subsequently relied on the service-worker scope metadata, while adjacent browser tests assert rewrite behavior. The callback materialization fixture retained the older exact shape, so the fixture rather than the owning contract was stale.The response metadata remains bounded optional contract output. This PR updates exact expectations rather than weakening them to partial matching.
Verification
npm run test:browser-callback-materialization-contractspassesnpm run test:service-worker-preview-proxypasses, 4/4npm run test:playground-contained-scopepasses, 1/1npm run buildpassesnpm run checkpasses the repaired callback contract, then stops at the independent pre-existing command-registry-smoke fails on main: wordpress.collect-workload-result outputShape missing outputSchema id mention #1745command-registry-smokefailure:wordpress.collect-workload-result outputShape should mention outputSchema id. Fresh reproduction recorded at command-registry-smoke fails on main: wordpress.collect-workload-result outputShape missing outputSchema id mention #1745 (comment)AI assistance
Fixes #2344