Skip to content

test: restore callback metadata contract - #2346

Merged
chubes4 merged 1 commit into
mainfrom
fix-2344-callback-metadata-contract
Aug 24, 2026
Merged

test: restore callback metadata contract#2346
chubes4 merged 1 commit into
mainfrom
fix-2344-callback-metadata-contract

Conversation

@chubes4

@chubes4 chubes4 commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • restore the exact callback materialization fixtures for bounded preview-proxy response metadata
  • assert normalized content length, service-worker root scope, and body rewrite semantics directly
  • retain exact object matching for redirect and truncated-response trace records

Root cause and contract decision

d4a734f8 intentionally added contentLength, serviceWorkerAllowed, and bodyRewritten to the typed bounded request trace for packaged-worker diagnostics. b86524a0 subsequently relied on the service-worker scope metadata, while adjacent browser tests assert rewrite behavior. The callback materialization fixture retained the older exact shape, so the fixture rather than the owning contract was stale.

The response metadata remains bounded optional contract output. This PR updates exact expectations rather than weakening them to partial matching.

Verification

AI assistance

  • AI assistance: Yes
  • Tool: OpenCode
  • Used for: contract investigation, test fixture updates, verification, and PR preparation

Fixes #2344

@chubes4
chubes4 merged commit 883914a into main Aug 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: callback materialization contract fixture rejects current service-worker response metadata

1 participant