Remove the per-endpoint locale parameter from WordPress.com requests - #1597
Merged
Conversation
Collaborator
XCFramework BuildThis PR's XCFramework is available for testing. Add to your .package(url: "https://github.com/automattic/wordpress-rs", branch: "pr-build/1597")Built from 97ea235 |
oguzkocer
force-pushed
the
remove/wpcom-endpoint-locale-params
branch
from
August 26, 2026 03:05
552bd62 to
b379528
Compare
Changes: - Drop the `locale` field and its query pair from `ProductsParams`, `SitePlansParams` and the `Stats*Params` types - Remove `StatsSummaryParams`, `StatsInsightsParams` and `LanguagesGetParams`, which carried nothing else, and drop `params` from their endpoints - Remove the unit and e2e tests that only covered the removed field
oguzkocer
force-pushed
the
remove/wpcom-endpoint-locale-params
branch
from
August 26, 2026 03:10
b379528 to
340bee2
Compare
`Exports.swift` re-exported the type, which no longer exists, so every Swift target failed to build.
oguzkocer
marked this pull request as ready for review
August 26, 2026 05:20
crazytonyli
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #1590.
Now that every WordPress.com request carries a locale from the client's
WpComLanguageProvider, the endpoints that declared their ownlocaleparameter no longer need one — and left in place they'd put the pair on the URL twice.Changes
localefield and its query pair fromProductsParams,SitePlansParamsand theStats*Paramstypes.StatsSummaryParams,StatsInsightsParamsandLanguagesGetParamscarried nothing else, so they're removed entirely.get_stats_summary,get_stats_insightsand the languagesgetnow take one fewer argument.Changelog
CHANGELOG.mdunder## [Unreleased], using the Keep a Changelog categories (Added,Changed,Deprecated,Removed,Fixed,Security). Prefix breaking changes with**BREAKING:**.