Repository navigation
Only approve feature requests for the requester's own collection - #3891
Merged
Merged
Conversation
3 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes:
instrument) belongs to the actor who sends the request. Before, the instrument only had to be on the actor's host, so another account on the same server could get a feature approval for a collection that is not theirs.idis exactly the requested instrument and that itsattributedTois the actor. If not, the request is rejected. FEP-7aa9 requiresattributedToon aFeaturedCollection.activitypub_handled_feature_requestdoes not fire in that case.Other information:
Same check as #3881 does for quote requests. It costs one request per FeatureRequest that the policy would accept, the result is cached.
Testing instructions:
activitypub_default_feature_policytoanyone.instrumentis a collection of another account on the same server: it is rejected and no stamp is created.Changelog entry
Changelog Entry Details
Significance
Type
Message
Feature requests are now only approved for collections that belong to the account asking.