Repository navigation
Conversation
Address PLTFRM-1650 in both Node.js and Go command notes and help text.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
🟢 Approval recommended
The wording is consistent across both runtimes and is covered by focused unit and parity regressions.
0 open findings
What changed in this PR
Clarifies platform-specific phpMyAdmin permissions consistently across the Node.js and Go CLIs.
Changes:
- Replaces the blanket read-only warning with platform-specific guidance.
- Removes read-only wording from command help and examples.
- Adds unit and differential parity coverage and refreshes drift fingerprints.
| File | Description |
|---|---|
src/commands/phpmyadmin.ts |
Updates the Node.js access note. |
src/bin/vip-db.ts |
Makes parent help platform-neutral. |
src/bin/vip-db-phpmyadmin.ts |
Updates the command example. |
cmd/vip-next/commands/db_phpmyadmin.go |
Updates Go help and access note. |
cmd/vip-next/commands/db_phpmyadmin_test.go |
Tests Go note, help, and silent behavior. |
__tests__/commands/phpmyadmin.ts |
Tests Node.js note suppression. |
internal/parity/phpmyadmin_scenario_test.go |
Adds cross-runtime note and help checks. |
testdata/parity/phpmyadmin-print.yaml |
Refreshes print drift fingerprint. |
testdata/parity/phpmyadmin-error.yaml |
Refreshes error drift fingerprint. |
testdata/parity/phpmyadmin-silent.yaml |
Clarifies silent-output expectations. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
There was a problem hiding this comment.
🟢 Approval recommended
Both runtimes consistently implement the scoped behavior with comprehensive resolver, command, and differential coverage.
0 open findings
Files not reviewed (1)
- internal/gql/generated.go: Generated file
🧠 Review effort: Balanced
| if opened != "" { | ||
| t.Errorf("--print must not open browser; got %q", opened) | ||
| } | ||
| if !strings.Contains(stderr.String(), "Note: phpMyAdmin sessions are read-only on VIP Kubernetes and read-write on WP Cloud.") { |
There was a problem hiding this comment.
we shouldn't expose this implementation detail.
Summary
Addresses PLTFRM-1650:
vip db phpmyadminincorrectly described WP Cloud sessions as read-only.Both Node.js and Go now request the nullable
isK8sResidentenvironment field and select the access note accordingly:true(VIP Kubernetes): retain the read-only warning.false(WP Cloud): print no access note.nullor omitted: retain the general note explaining the difference between platforms.Command help and examples no longer describe all sessions as read-only. Database permissions,
--silent, and existing output channels remain unchanged.Regression coverage includes both app lookup paths, all four metadata cases, silent output, and real Node/Go command and help comparisons. Existing documented output-channel drift is unchanged.
Validation
-race; the fullinternal/appctxpackage also passed with-race.make lint,make verify-gql-stale, andgit diff --checkpassed.The full Go suite was not run because browser-stubbing follow-up #3098 remains separate.