Skip to content

fix: preserve registry recursion fallbacks - #1080

Merged
chubes4 merged 1 commit into
trunkfrom
fix/pattern-recursion-fallbacks
Aug 23, 2026
Merged

fix: preserve registry recursion fallbacks#1080
chubes4 merged 1 commit into
trunkfrom
fix/pattern-recursion-fallbacks

Conversation

@chubes4

@chubes4 chubes4 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • route Accordion, Disclosure, and Navigation brand-carrier recursion through PatternRecursiveConverter
  • preserve recursive fallback diagnostics transactionally with the winning pattern result
  • remove three parallel recursion callbacks from PatternContext and three fallback-discarding HtmlTransformer wrappers
  • keep Navigation probe contexts recursion-free

Closes #919. This is the next bounded PatternContext simplification slice from #242.

Behavior proof

  • Accordion and Disclosure retain html_unsupported_element evidence from valid panels containing unsupported children
  • Navigation retains recursive brand diagnostics only when the brand carrier wins
  • Navigation probe context performs no recursive conversions
  • excluded-tag conversion preserves fallback ordering through the typed converter

Verification

  • composer test on current trunk
  • 12 staged-dispatch assertions
  • 280 parity fixtures
  • package install proof

AI assistance

OpenAI GPT-5.6 Sol via OpenCode was used to trace the remaining fallback-discarding recursion paths, consolidate them into the typed converter, add transactional behavior coverage, rebase onto current trunk, and run verification. Chris Huber is responsible for every line.

@chubes4
chubes4 merged commit ced972e into trunk Aug 23, 2026
4 checks passed
@chubes4
chubes4 deleted the fix/pattern-recursion-fallbacks branch August 23, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve fallback diagnostics across pattern recursion

1 participant