40 fix schema translate map rel class - #41
Open
nicoloesch wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
relationship-classificationwas writing outside the configured CDM schemaDROP TYPEno-op plus unqualified staging-table SQL.OMOPAlchemyImplementation) resolved a database URL but discarded itsschema_translate_map, silently ignoring the configured schema for all ontology/concepttraversal, not just this one command.
omop_resource()/OMOPAlchemyImplementationnever wired a configured split vocabulary connection through to a real second engine at allKnowledgeGraphsilently collapsed to one connection whenever a caller, including every production path, omittedvocab_engineexplicitly.Fix
relationship-classificationnow respects the configured CDM schema end to endschema_translate_mapthrough to the engine it builds, and skips engine construction entirely when a caller injectskg=directly.omop_resource()now builds both the primary and vocabulary engines via oa-configurator'screate_engines(), andOMOPAlchemyImplementationaccepts and forwards a realvocab_engineChecklist
breaking,feature,fix,dependencies, orchore)uv run pytest -q): 46 passeduv run ruff check .)