chore: gen3-validator 2.2.0 + real-resolver integration tests - #10
Merged
Conversation
…on tests The 2.2.0 resolver is bundle-aware: node-level $refs into _terms.yaml (the official Gen3 dictionary's shape) now resolve instead of silently dropping the node from the resolved schema. The existing suite mocks gen3_validator entirely, so upstream resolution regressions were invisible to CI — the new integration tests run the real resolver and validator over a small bundle covering the previously-broken shapes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
poetry.lock: gen3-validator 2.1.0 -> 2.2.0 (the dependency range>=2.0.0,<3.0.0already allows it; the lock matters because the publish workflow installs from it).tests/test_validator_integration.py: two tests running the REALgen3_validatorresolver and validator (everything else in the suite mocks it), covering the shapes 2.2.0 fixed — node-level$refinto_terms.yamland theUUIDterms/definitions collision — and proving a resolved$refbecomes an enforceable constraint end to end.Why
gen3-validator 2.2.0 makes
$refresolution bundle-aware. Before it, the validation Glue job could not process the official Gen3 dictionary unstripped: nodes with term refs were silently dropped from the resolved schema and their data was never validated. Because this repo's tests mockgen3_validatorentirely, that class of regression was invisible to CI; the integration tests close that gap.Note on rollout: no toolkit release is required for deployed pipelines — Glue jobs pip-resolve gen3-validator from the toolkit's dependency range at job start, so they pick up 2.2.0 on the next run.
Verification
poetry run python3 -m pytest -q— 350 passed (348 existing + 2 new) against the updated lock.