Skip to content

fix(notifications): load weekly rotation notifications and show failures - #14616

Merged
raymondjacobson merged 1 commit into
mainfrom
codex/fix-notifications-weekly-rotation
Oct 2, 2026
Merged

raymondjacobson merged 1 commit into
mainfrom
codex/fix-notifications-weekly-rotation

Conversation

@raymondjacobson

@raymondjacobson raymondjacobson commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

A weekly_rotation notification causes the SDK's generated discriminator parser to throw, rejecting the entire notifications response before the existing UI adapter can process it. This updates the generated notification models from the current Audius API schema and moves weekly rotation into the adapter's typed switch.

The desktop notification panel now shows an explicit spinner during the initial request and an error with a retry button on failure. Loaded notifications remain visible if a later request fails, and pagination avoids overlapping requests. Includes an SDK patch changeset.

Validation:

  • Reproduced the parser failure before the fix; all 9 focused regression tests pass (mixed notification responses, serialization, initial loading, empty state, retry, and pagination).
  • Full GitHub CI passed on 9c70ca6: SDK CI, web tests, web typecheck, web lint/stylelint, web production build, identity tests/typecheck/lint, and security checks.
  • Focused local ESLint and generated SDK type checks also pass.

@changeset-bot

changeset-bot Bot commented Oct 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9c70ca6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@audius/sdk Patch
@audius/sdk-legacy Patch
@audius/protocol-dashboard Patch
@audius/sp-actions Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@raymondjacobson
raymondjacobson merged commit 2633593 into main Oct 2, 2026
24 checks passed
@raymondjacobson
raymondjacobson deleted the codex/fix-notifications-weekly-rotation branch October 2, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant