fix(contest): style contest share as a proper harmony button#14528
Open
dylanjeffers wants to merge 1 commit into
Open
fix(contest): style contest share as a proper harmony button#14528dylanjeffers wants to merge 1 commit into
dylanjeffers wants to merge 1 commit into
Conversation
The contest page share action rendered as a bare IconButton — an unstyled arrow icon sitting next to the properly styled Follow and Enter Contest buttons. Replace it with an icon-only secondary Button (size small) so it matches the height, border, and hover treatment of the neighboring actions, per the Figma spec and the same pattern used by the profile StatBanner action row. Update the loading skeleton to match the new rectangular shape. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The share action on the contest page rendered as a bare
IconButton— an unstyled arrow icon sitting awkwardly next to the properly styled Follow and Enter Contest buttons.This replaces it with an icon-only harmony
Button(variant='secondary',size='small',iconLeft={IconShare}), matching the Figma design and the height/border/hover treatment of the neighboring buttons. It's the same icon-only button pattern already used by the profile pageStatBanneraction row. The header loading skeleton is updated to match the new rectangular shape.Before: bare arrow icon, no button chrome
After: bordered secondary button, 32px tall like Follow / Enter Contest, purple fill on hover
How Has This Been Tested?
/soundsbymystic/contest/mstic-dfwm-1):aria-label="Share contest"preservedeslintpasses on the modified file🤖 Generated with Claude Code