fix(privacy): hide profile photo and banner for deactivated accounts#14522
Merged
Conversation
Deactivated/deleted accounts were still exposing their profile picture and cover photo (e.g. an account that requested deletion still showed their images on the profile page). This is a privacy/GDPR concern. When is_deactivated is true, force the default placeholder for both the profile picture and cover photo instead of the user's uploaded images. Applied centrally in the web and mobile useProfilePicture/useCoverPhoto hooks so the placeholder renders everywhere those images appear, plus defensive handling in the web profile page components. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A deactivated/deleted artist account (reported in Slack:
audius.co/cyranomusic) still displayed their profile photo and banner on the profile page. This is a privacy/GDPR concern — a user who deletes their account should no longer have their uploaded images shown.Fix
When
is_deactivatedistrue, force the default placeholder for both the profile picture and the cover photo instead of resolving the user's uploaded images.The fix is applied centrally in the shared image hooks so the placeholder renders everywhere a deactivated user's avatar/banner would otherwise appear (profile page, comments, follower lists, cards, etc.), not just the profile page:
packages/web/src/hooks/useProfilePicture.ts,packages/web/src/hooks/useCoverPhoto.tspackages/mobile/src/components/image/UserImage.tsx(useProfilePicture),packages/mobile/src/components/image/CoverPhoto.tsx(useCoverPhoto)Plus explicit/defensive handling in the web profile page components:
packages/web/src/pages/profile-page/components/desktop/ProfilePage.tsxpackages/web/src/pages/profile-page/components/mobile/ProfileHeader.tsxPlatforms
Testing
🤖 Generated with Claude Code