Convert the MS packet's contents to JSON, Client edition#1081
Conversation
There was a problem hiding this comment.
This and it's cpp half are actually exactly the same on both Akashi and here.
It might be wise to relocate these two into a repo of their own, and then git submodule them into both, or something along those lines.
…rame SFX-es being sent over malformed
- Fix an issue where own offset was not sent over - Fix an issue where the pair's emote wasn't read from the JSON - Fix an issue where pair would be displayed no matter if they should be or not
|
The PR is ready to review. I tested all I could, but it obviously needs a much more intensive testing. |
Salanto
left a comment
Salanto
left a comment
There was a problem hiding this comment.
This should be merged after the next check-in. It works, but needs extensive testing since we are breaking the chat protocol here.
|
Turning the packets to JSON is a good idea and there stands to be benefits for web as well from this, thank you for your work. This PR is getting stale and its unlikely it will be accepted without a testing period. While this will be closed, if this or a similar concept is still planned, this is an acceptable PR for use in the Experimental AOS repo: https://github.com/AttorneyOnlineChaos/AO-CHAOS-Client. |
3 participants
The other half of the Akashi PR.
Unlike that one, this one is very heavily in progress.