feat: update contact form to use npm package - #698
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Hey, nice to have you here @sifterstudios! Deleting 11k lines of code is certainly one way to make an entrance 🔥 Is the source code of |
Hello, hello! 🔥🌪️
|
|
Update @rosvik - repo moved here: https://github.com/atb-AS/mrfylke-contact-form |
rosvik
left a comment
rosvik
left a comment
There was a problem hiding this comment.
Had a look through this now with @strandlie, and I think it makes sense overall 👍 A couple of questions:
- Theme and language doesn't seem to be synced between contact form and the main application. Could we use the same cookie for both?
- Comments 👇
| return Icon; | ||
| } | ||
|
|
||
| const iconSet: ContactFormConfig['icons'] = { |
There was a problem hiding this comment.
Why are icons passed in as configuration? Could contact-form take them directly from generate-assets instead?
rosvik
left a comment
rosvik
left a comment
There was a problem hiding this comment.
@sifterstudios If you don't have the time to look into the comments, I think this is a nice change as is ✨ (Or, shout if you disagree, @strandlie 👀)
I fixed the merge conflicts now - is there anything else blocking us from merging? Do you have time to test it for FRAM in the near future?
35ba029 to
f64306f
Compare
f64306f to
2d9835e
Compare
aka hide 'ticketBoughtOnBus'
not relevant with Pages Router
a496651 to
76db49a
Compare
3 participants
this PR transfers the contact-form from being embedded in planner-web to being imported from @mrfylke/contact-form. Has been tested locally, looks to have identical functionality.
Would appreciate some new eyes on this and advice on testing the submit call with e2e testing.