Trim dead sensitive-logging wrappers and document scope#2290
Merged
Conversation
Contributor
|
Hi @hyperxpro ! Sorry for messaging you here, but I wasn’t sure where else I could reach you. I just have a quick question: is there any information about the date of the next release? |
Member
Author
Hopefully next week as I am blocked by GitHub on some items for the release. |
Contributor
|
@hyperxpro thanks for information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Non-blocking follow-ups from the PR #2279 review: dead public API surface, an undocumented invariant, and an undocumented scope gap.
Modification:
Removed unused HttpMessageFormatter.REDACTED/isSensitiveHeader wrappers, added an invariant comment to NettyRequest, and documented the redaction scope in SensitiveLoggingUtils javadoc.
Result:
No functional change