Repository navigation
Consume TTS requests from a deque, not list.pop(0) - #281
Merged
Merged
Conversation
pop(0) shifts every remaining chunk, so a long --url/PDF text did quadratic work queueing its requests; deque.popleft() is O(1). (Aikido review.) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #279, addressing Aikido's review comment. #279 entered the merge queue before this could be pushed.
The multi-request TTS loop in
tts/session.pytook chunks withpending.pop(0), which shifts every remaining chunk, so a long--url/PDF text did quadratic work queueing its requests.pendingis now acollections.dequeconsumed withpopleft(), which is O(1) per chunk. Behavior is unchanged: still at most 3 requests in flight, sent in order../scripts/check.sh: All checks passed. The existing multi-request tests intests/test_tts_session_multi.pycover the ordering and in-flight bound.🤖 Generated with Claude Code