Skip to content

Fix: Calculate em unit based on font size rather than line height #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chenjt2001 wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Fix: Calculate em unit based on font size rather than line height #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/HtmlRenderer/Core/Dom/CssBoxProperties.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1432,7 +1432,7 @@ public double ActualBorderSpacingVertical
/// <returns></returns>
public double GetEmHeight()
{
return ActualFont.Height;
return ActualFont.Size * 96d / 72d;

@jhaygood86 jhaygood86 Jul 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we hard-code a DPI assumption?

The correct answer at this layer should probably be ActualFont.Size.

}

/// <summary>
Expand Down