Fix failing update-citations workflow (timeout, NameError, git add crash) - #1
Merged
Merged
Conversation
Co-authored-by: Arthod <32404077+Arthod@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job update-citations
Fix failing update-citations workflow (timeout, NameError, git add crash)
Aug 4, 2026
Arthod
marked this pull request as ready for review
August 4, 2026 22:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
update-citationsCI job was failing with two cascading errors: thescholarlyfetch timed out after 90s (exit 124), thengit add _data/citations.ymlcrashed with exit 128 because the file was never created.Root causes fixed:
NameErrorinbin/update_scholar_citations.py:existing_datawas assigned only insideif os.path.exists(OUTPUT_FILE)but referenced unconditionally at line 112. Initialized toNonebefore the block.git addexit 128:git add _data/citations.ymlfails when the file doesn't exist (script timed out or errored). Added a file-existence guard — skips commit step gracefully if no file present.timeoutfrom 90s → 300s;scholarlymakes multiple retried network requests to Google Scholar and reliably exceeded 90s.Ownership Routing
docs/BOUNDARIES.md.al-folio) or I am porting a routed change and linked the owning repo issue/PR.Owning repo (if not starter):
Related issue/PR:
Plugin Ecosystem (if applicable)
Starter Wiring Changes
Validation
npm cibundle exec jekyll buildnpm run lint:prettiernpm run lint:style-contracttest/integration_*.sh) as needednpm run test:visual) as neededNotes
The underlying
scholarlynetwork calls may still be flaky (Google Scholar rate-limits scrapers). If timeouts persist at 300s, consider adding a free proxy viascholarly.use_proxy()or caching results more aggressively.