Skip to content

FilterReview: link to the how to use steps on the wiki - #364

Open
j-w9 wants to merge 3 commits into
ArduPilot:mainfrom
j-w9:filter-review-guide
Open

j-w9 wants to merge 3 commits into
ArduPilot:mainfrom
j-w9:filter-review-guide

Conversation

@j-w9

@j-w9 j-w9 commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Following the review, the how to use steps now live on the wiki (ArduPilot/ardupilot_wiki#8196) instead of in the tool, so there's one set of instructions. This just adds a line to the intro linking to that section.

The link goes to common-raw-imu-logging.html#using-the-filter-review-tool, so it needs the wiki PR merged first.

HTML only.

This was AI assisted (Claude Code), and I reviewed it.

@IamPete1

Copy link
Copy Markdown
Member

I think I would rather have documentation on the wiki which we link too. I want to avoid having multiple sets of instructions which don't match. @Hwurzburg any thoughts?

@Hwurzburg

Copy link
Copy Markdown
Contributor

I agree...adding this on Ardupilot.org/dev/docs/common-webtools would be a worthwhile expansion of the FilterReivew section

@j-w9

j-w9 commented Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

Ill shift to there and link it in this pr

@j-w9
j-w9 force-pushed the filter-review-guide branch from 3485615 to a4dd4d1 Compare October 24, 2026 20:05
@j-w9 j-w9 changed the title FilterReview: add a step by step how to use guide FilterReview: link to the how to use steps on the wiki Oct 24, 2026
@IamPete1

Copy link
Copy Markdown
Member

Ill shift to there and link it in this pr

Thanks!

@tridge tridge added the AIReview label Nov 9, 2026
@AP-Review

AP-Review commented Nov 9, 2026 •

Copy link
Copy Markdown

Deprecated — see below for the updated review.

Previous review (2026-11-09)

Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting.
Verdict: ACCEPT

Reviewed at head b929b9fd7d.
Full report: https://firmware.ardupilot.org/Tools/APReview/DevCallReviews/PRReviews/ardupilot/webtools/364/1.html#prWebTools-364

This one-line link to the wiki's Filter Review instructions looks good to merge once the companion wiki PR is in.

Note

@AP-Review

Copy link
Copy Markdown

Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting.
Verdict: ACCEPT

Reviewed at head f243b1e13c.
Full report: https://firmware.ardupilot.org/Tools/APReview/DevCallReviews/PRReviews/ardupilot/webtools/364/2.html#prWebTools-364

This one-line link to the wiki's Filter Review instructions is good to merge after ArduPilot/ardupilot_wiki#8196. Since the last review, the link now targets the explicit wiki label #common-raw-imu-logging-filter-review, so a heading rename won't break it.

Note

@Hwurzburg
Hwurzburg requested a review from IamPete1 November 9, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants