Skip to content

Libraries: add common.css for styles shared by the tools - #361

Open
j-w9 wants to merge 2 commits into
ArduPilot:mainfrom
j-w9:shared-css
Open

j-w9 wants to merge 2 commits into
ArduPilot:mainfrom
j-w9:shared-css

Conversation

@j-w9

@j-w9 j-w9 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

A first step towards keeping style in CSS rather than inline. This adds Libraries/common.css and moves the styles repeated across the tool pages into it:

  • the rule hiding Plotly notifications (in 14 pages' <style> blocks)
  • the header table width and GitHub logo sizes (17 pages)
  • the colour and underline of the title link (18 pages)

Pages render exactly as before. Screenshots of all 18 changed pages are pixel-identical to main. GeofenceGenerator has its own header layout and is left as is.

This also gives somewhere to put a dark theme, which I'll follow up with separately.

Move the styles repeated on each page into one stylesheet:
- the rule hiding Plotly notifications
- the page header table and GitHub logo sizes
- the colour and underline of the title link

Pages render exactly as before.
@AP-Review

AP-Review commented Nov 9, 2026 •

Copy link
Copy Markdown

Deprecated — see below for the updated review.

Previous review (2026-11-09)

Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting.
Verdict: ACCEPT

Reviewed at head 7c947483c8.
Full report: https://firmware.ardupilot.org/Tools/APReview/DevCallReviews/PRReviews/ardupilot/webtools/361/1.html#prWebTools-361

This CSS consolidation looks good: rendering is unchanged on all 18 pages in Chromium, and eslint passes on this head.

Minor (1)
  • DFULoader/index.html:6 — the new common.css <link> is at column 0; the other <head> lines are indented 4 spaces. Optional tidy-up.

@AP-Review

Copy link
Copy Markdown

Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting.
Verdict: ACCEPT

Reviewed at head af465624db.
Full report: https://firmware.ardupilot.org/Tools/APReview/DevCallReviews/PRReviews/ardupilot/webtools/361/2.html#prWebTools-361

This CSS consolidation still looks good at af46562: computed styles match base on all 18 pages in headless Chromium, and eslint passes. Since the last review, the indentation of the common.css link in DFULoader/index.html:6 has been fixed, and there are no open findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants