Repository navigation
Conversation
The brief maps every export to `<module>::<name>`, so a default export became `app::plugin::default`, an item no Rust module can hold, while `done` already skips default exports. The brief now says a default export has no Rust item of its own and names the two `--map` forms `done` accepts. Adds an end-to-end test.
There was a problem hiding this comment.
🟢 Approval recommended
The focused change is correct and covered by an appropriate workflow test.
0 open findings
What changed in this PR
Updates porting briefs to avoid inventing invalid Rust paths for TypeScript default exports.
Changes:
- Describes valid
--mapoptions for default exports. - Adds end-to-end coverage for named and default exports.
| File | Description |
|---|---|
src/brief.rs |
Renders actionable default-export guidance. |
tests/porting_workflow.rs |
Verifies generated export mappings. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The brief maps every export to
<module>::<name>, so a default exportbecame
app::plugin::default, an item no Rust module can hold, whiledonealready skips default exports. The brief now says a defaultexport has no Rust item of its own and names the two
--mapformsdoneaccepts.Testing: a new end-to-end test in
tests/porting_workflow.rsfails onmainand passes with the change.cargo fmt --check,cargo clippy --all-targets -- -D warningsandcargo testpass.