Repository navigation
Let the Zinc counter be narrowed to a path - #45
Merged
Merged
Conversation
The deployed servers count only what arrives under /api - AGBaseUriSpace sets that prefix before installing the counter. Canopy's counter subscribed to every transaction, so after the migration zinc_httpRequests and zinc_httpResponses would have carried materially different numbers, the scrapes of the metrics endpoint among them. pharo-metrics says as much where it filters: left alone, a counter of HTTP requests counts the requests that read it. Two lists rather than the single flag pharo-metrics uses, where addInclude and addExclude overwrite each other's mode and the last call wins: named prefixes narrow what is counted, excluded ones drop out of what is left, and with neither everything counts. That covers what the servers do and has no order in which it means something else. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deployed servers count only what arrives under /api - AGBaseUriSpace sets that prefix before installing the counter. Canopy's counter subscribed to every transaction, so after the migration zinc_httpRequests and zinc_httpResponses would have carried materially different numbers, the scrapes of the metrics endpoint among them. pharo-metrics says as much where it filters: left alone, a counter of HTTP requests counts the requests that read it.
Two lists rather than the single flag pharo-metrics uses, where addInclude and addExclude overwrite each other's mode and the last call wins: named prefixes narrow what is counted, excluded ones drop out of what is left, and with neither everything counts. That covers what the servers do and has no order in which it means something else.