Skip to content

feat(login): ft login --read-only - #56

Merged
LucasLeguizamo merged 3 commits into
mainfrom
feat/login-read-only
Nov 10, 2026
Merged

LucasLeguizamo merged 3 commits into
mainfrom
feat/login-read-only

Conversation

@LucasLeguizamo

Copy link
Copy Markdown
Contributor

Qué cambia

  • ft login --read-only abre /device con ?scope=read, que pre-marca "Solo lectura". Al volver, consulta GET /me y se niega a guardar la key si scope no es read. Pasa si quien aprobó desmarcó la casilla, si --key es una key write o si el servidor es anterior a 1.43.0. En los tres casos falla cerrado.
  • ft whoami (multi-cuenta) muestra la columna scope. El login avisa "(read-only)".
  • openapi.json → 1.43.0. Es un parche mínimo (versión + schema Me): el contenido es idéntico al de free-admin, verificado por ft-contract-impact.

Depende de AppFreeticket/free-admin#1220, que agrega scope a /me y el checkbox en /device. Mergear esa primero. Si esta sale antes, --read-only falla cerrado y no se abre ningún hueco.

Límite conocido: la key write que se rechaza queda viva en el backend. Nadie tiene su secreto; si se acumulan, se revocan (ponytail: en readOnlyRefusal).

Diagrama de flujo

flowchart LR
  A["ft login --read-only"] --> B["browser /device?scope=read"]
  B --> C["GET /me"]
  C --> D{"scope == read"}
  D -->|sí| E["guarda la cuenta"]
  D -->|no| F["falla, no guarda"]
Loading

Cómo probar

  1. pnpm test (src/commands/auth.test.ts: withQuery conserva code; rechaza write/undefined; acepta read).
  2. Contra free-admin con #1220: FT_API_URL=http://admin.localhost:3000 ft login --read-only. Aprobar con la casilla marcada guarda la cuenta; desmarcada, falla sin guardar.
  3. ft whoami muestra scope: read. Un comando de escritura (p. ej. ft events create) recibe 403.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Fo7cm6tJ2XF1A7EL6t4KGF

LucasLeguizamo and others added 3 commits November 10, 2026 15:57
Pre-marca "Solo lectura" en /device y se niega a guardar una key que pueda
escribir. whoami muestra el scope. Contrato 1.43.0 (GET /me trae scope).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fo7cm6tJ2XF1A7EL6t4KGF
Doco-Brief: https://doco.to/workspaces/appfreeticket/brief?id=brief_01M73KQRZBD3XRSHWMP3Z8FW6P
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fo7cm6tJ2XF1A7EL6t4KGF
@LucasLeguizamo LucasLeguizamo added the enhancement New feature or request label Nov 10, 2026
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@LucasLeguizamo
LucasLeguizamo merged commit 5e63100 into main Nov 10, 2026
2 checks passed
@LucasLeguizamo
LucasLeguizamo deleted the feat/login-read-only branch November 10, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant