Skip to content

chore(contract): sync v1 1.42.0 and admin 1.8.0 from production - #55

Merged
lu-ochenty merged 1 commit into
mainfrom
chore/contract-sync-v1-1.42
Nov 10, 2026
Merged

lu-ochenty merged 1 commit into
mainfrom
chore/contract-sync-v1-1.42

Conversation

@LucasLeguizamo

Copy link
Copy Markdown
Contributor

Brings the committed contracts up to production (https://admin.appfreeticket.com), pulled with pnpm sync-openapi and pnpm sync-openapi:admin.

Contract Before After
B2B /api/v1 (openapi.json) 1.38.0 (153 paths) 1.42.0 (157 paths, 213 operations)
Superadmin /api/admin (admin-openapi.json) 1.5.1 (17 paths) 1.8.0 (27 paths, 36 operations)

No command changes. The large line count in openapi.json is mostly upstream path reordering: free-admin now emits paths in a different order. The semantic diff is below.

Changes

Path Contract Kind Affected command Bump
GET/POST /customer/addresses, PATCH/DELETE /customer/addresses/{id} v1 additive (new) none (buyer address book, no command yet) patch
GET /customer/merch-orders v1 additive (new) none patch
POST /merch/discount-codes/preview v1 additive (new) none patch
GET /merch/catalog: optional X-Merch-Preview header v1 additive none patch
POST /merch/orders: optional discountCode; .../payment/card: optional issuerId v1 additive none patch
POST /merch/products: optional maxPerCustomer, membersOnly v1 additive ft merch products create (works unchanged; the fields are not exposed yet) patch
MerchAdminProduct: new response fields maxPerCustomer, membersOnly; MerchOrder: discountCode, discountAmount v1 additive (response) test fixture only patch
PATCH /merch/products/{id}/status, POST /merch/products/images/upload-url: declared 400 v1 additive (docs) none patch
11 new /crm/* operations (campaigns, audience preview, batches, quota, options, events, event-dates) admin additive (new) none here (ft admin crm lives in #50) patch
role enum gains MERCH_MANAGER (AdminUser, AdminMe, PATCH /users/{id}) admin additive (new enum value) ft admin users prints it as-is patch
Nullable fields rewritten from anyOf [T, null] to type: [T, "null"] admin neutral (same shape) none —

Breaking changes: none. No operationId was removed or renamed, no new required request field, no type change.

The only client-side adjustment is in src/commands/merch.test.ts: the MerchAdminProduct fixture gains maxPerCustomer: null and membersOnly: false, which the generated type now requires.

Suggested bump: patch. A changeset is included (.changeset/contract-sync-1-42.md → 0.13.1). Merging publishes through the release workflow.

Note: #53 (feat/p1-ops) and #50 (feat/admin-crm) also touch openapi.json / admin-openapi.json. Whichever merges second should re-run pnpm sync-openapi instead of resolving the JSON by hand.

Test results

  • pnpm generate: ok
  • pnpm typecheck: ok
  • pnpm test: 10 files, 103 tests passed
  • pnpm lint: clean (2 pre-existing infos)

🤖 Generated with Claude Code

https://claude.ai/code/session_01Fo7cm6tJ2XF1A7EL6t4KGF

B2B v1 1.38.0 -> 1.42.0 and superadmin 1.5.1 -> 1.8.0, pulled with
`pnpm sync-openapi` / `pnpm sync-openapi:admin`. Additive only: no
operationId removed or renamed. The merch test fixture gains the two
fields MerchAdminProduct now requires (maxPerCustomer, membersOnly).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fo7cm6tJ2XF1A7EL6t4KGF
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@lu-ochenty
lu-ochenty merged commit 8f51fa0 into main Nov 10, 2026
1 of 2 checks passed
@lu-ochenty
lu-ochenty deleted the chore/contract-sync-v1-1.42 branch November 10, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants