Repository navigation
chore(contract): sync v1 1.42.0 and admin 1.8.0 from production - #55
Merged
Merged
Conversation
B2B v1 1.38.0 -> 1.42.0 and superadmin 1.5.1 -> 1.8.0, pulled with `pnpm sync-openapi` / `pnpm sync-openapi:admin`. Additive only: no operationId removed or renamed. The merch test fixture gains the two fields MerchAdminProduct now requires (maxPerCustomer, membersOnly). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fo7cm6tJ2XF1A7EL6t4KGF
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the committed contracts up to production (
https://admin.appfreeticket.com), pulled withpnpm sync-openapiandpnpm sync-openapi:admin./api/v1(openapi.json)/api/admin(admin-openapi.json)No command changes. The large line count in
openapi.jsonis mostly upstream path reordering: free-admin now emits paths in a different order. The semantic diff is below.Changes
GET/POST /customer/addresses,PATCH/DELETE /customer/addresses/{id}GET /customer/merch-ordersPOST /merch/discount-codes/previewGET /merch/catalog: optionalX-Merch-PreviewheaderPOST /merch/orders: optionaldiscountCode;.../payment/card: optionalissuerIdPOST /merch/products: optionalmaxPerCustomer,membersOnlyft merch products create(works unchanged; the fields are not exposed yet)MerchAdminProduct: new response fieldsmaxPerCustomer,membersOnly;MerchOrder:discountCode,discountAmountPATCH /merch/products/{id}/status,POST /merch/products/images/upload-url: declared400/crm/*operations (campaigns, audience preview, batches, quota, options, events, event-dates)ft admin crmlives in #50)roleenum gainsMERCH_MANAGER(AdminUser,AdminMe,PATCH /users/{id})ft admin usersprints it as-isanyOf [T, null]totype: [T, "null"]Breaking changes: none. No operationId was removed or renamed, no new required request field, no type change.
The only client-side adjustment is in
src/commands/merch.test.ts: theMerchAdminProductfixture gainsmaxPerCustomer: nullandmembersOnly: false, which the generated type now requires.Suggested bump: patch. A changeset is included (
.changeset/contract-sync-1-42.md→ 0.13.1). Merging publishes through the release workflow.Note: #53 (feat/p1-ops) and #50 (feat/admin-crm) also touch
openapi.json/admin-openapi.json. Whichever merges second should re-runpnpm sync-openapiinstead of resolving the JSON by hand.Test results
pnpm generate: okpnpm typecheck: okpnpm test: 10 files, 103 tests passedpnpm lint: clean (2 pre-existing infos)🤖 Generated with Claude Code
https://claude.ai/code/session_01Fo7cm6tJ2XF1A7EL6t4KGF