Repository navigation
feat(merch): ft merch products (list, create, images, publish) - #54
Merged
Merged
Conversation
…o 1.38) Carga productos de la tienda de merch sin el panel, sobre los endpoints nuevos de /api/v1/merch/products: - list: todos los productos (DRAFT y PUBLISHED) con variantes. - create: --name, --price (COP), --sizes XS,S,M (una variante por talla), --stock, --image <path> repetible. Valida las fotos localmente, crea el producto (siempre DRAFT), sube cada foto por la URL firmada y fija la lista en orden. --publish lo publica al final; --from-json crea varios y sigue aunque falle uno, nombrando cuál y en qué paso. - publish / unpublish <id>. openapi.json sincronizado con free-admin 1.38.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fo7cm87scmq5VLvMxkSjM6
…durecida
Ronda de QA de `ft merch products`:
- `ft merch products images <id> --image …` sube fotos locales y reemplaza
las del producto: repara un `create` que falló después de crear.
- `create --json` imprime `{ created, failed: [{ name, productId?, step,
error }] }` aunque falle alguno; sin --json, la tabla de lo creado va a
stdout y las fallas a stderr (exit 1).
- 409 SKU_TAKEN / SLUG_TAKEN al recrear explica cómo recuperarse (list →
images → publish).
- Un 429 al pedir la URL de subida espera `Retry-After` y reintenta una
sola vez.
- Todo el lote se valida antes del primer request: forma de cada fila en
runtime (images/sizes arrays, stock no negativo, máx. 10 fotos) y cada
foto por magic bytes (JPEG, PNG, WebP), no por extensión.
- --from-json rechaza paths absolutos, `..` fuera de la carpeta del archivo
y symlinks.
- sizeBytes es el tamaño de los bytes que realmente se suben.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fo7cm87scmq5VLvMxkSjM6
LucasLeguizamo
marked this pull request as ready for review
November 3, 2026 21:49
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comandos
ft merch productssobre los endpoints/api/v1/merch/products*(contrato 1.38.0, AppFreeticket/free-admin#1184).Borrador: depende de que free-admin#1184 esté mergeada y desplegada.
Qué cambia
listcreate, con talla, stock,--imagerepetible y--from-jsonpara cargar en loteimages <id>, para reparar un productopublish <id>yunpublish <id>--from-json, las imágenes solo pueden estar dentro de la carpeta del JSON: sin rutas absolutas, sin..y sin symlinks;Retry-After;--json, la salida trae{created, failed}.Cómo probar
pnpm test. Contra un workspace Legend con una keywrite:ft merch products create --name Prueba --price 50000 --sizes S,M --stock 2 --image ./a.jpg.🤖 Generated with Claude Code
https://claude.ai/code/session_01Fo7cm87scmq5VLvMxkSjM6