Fixed Language prefix keys not working & Made it so other Garou forms have differing tongues - #133
Closed
TheTrueSilverRat wants to merge 41 commits into
Closed
Conversation
## About The Pull Request adds uncontrollable from v3 brujahbook, sets frenzy difficulty to 10 ## Why It's Good For The Game more book traits ! ## Changelog :cl: add: Added the Uncontrollable flaw for Brujah /:cl:
## About The Pull Request Cool datum we can use to parse out some behavoir based on what book types come from (including displaying such to the end-user so they can look it up themselves) ## Why It's Good For The Game We already like to mark where stuff comes from with comments, why not codify it and let it be used for behavior. ## Changelog :cl: code: new var on datum level for storing info on what source book it comes from config: Adds config for limiting merit based on official status /:cl:
## About The Pull Request landmark for the red news guy ## Why It's Good For The Game linters bleh ## Changelog :cl: code: adds a landmark for the red news reporter /:cl:
## About The Pull Request Adds proper subtypes & directionals for the fluffy TVs THEYRE EVEN ANIMATED HOW FREAKING AWESOME IS THAT Credit to GhoulPen for the new sprites ## Why It's Good For The Game More directionals are a mapping win. <img width="414" height="418" alt="dreamseeker_Px5BaFwPIW" src="https://github.com/user-attachments/assets/9adbb202-6dfc-4da0-8694-45deff9b3b1f" /> ## Changelog :cl: KCartridge add: proper TV subtypes add: directionals for TV /:cl:
## About The Pull Request upstream port of Monkestation#95 exactly what it says on the tin - Open Seal now works on cars too. ## Changelog :cl: add: Open Seal can now unlock cars. /:cl:
## About The Pull Request Shifts them from flags it checks for in a loop to just directly calling a proc as only one stat has these flags making them kinda pointless. ## Why It's Good For The Game Ensures its easier to write code that changes mob stats based on there stats and that its easy to make sure its ALWAYS updated and doenst need a helper called after every update. ## Changelog :cl: code: Changing stats based on stamina or dexterity is handled smarter /:cl:
## About The Pull Request Free memory. ## Why It's Good For The Game Each mob has alot of stats. This means they have a lot of lists. Lists eat memory ## Changelog :cl: code: makes some stat lists properly lazylists /:cl: --------- Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
## About The Pull Request Guide says TG alot and has some outdated info, but more importantly, it says nothing for AI which we do have a strong policy for atleast internally. --------- Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
## About The Pull Request <img width="401" height="243" alt="image" src="https://github.com/user-attachments/assets/991d3a7c-d058-45bd-8676-9fce9839c7a2" /> ## Changelog :cl: add: ported discipline stat descriptions from TFN /:cl: --------- Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com> Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
## About The Pull Request tfn port of corax waddling, wing flap sounds <img width="250" height="182" alt="dreamseeker_jyuSF5K7tf" src="https://github.com/user-attachments/assets/34703b2c-9766-4e12-8880-2cbcad38bf73" /> ## Changelog :cl: add: plays a sound when corax toggle flight add: gives corax a waddle when walking in bird form /:cl: --------- Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
## About The Pull Request <img width="268" height="126" alt="image" src="https://github.com/user-attachments/assets/6b6f1c18-1956-46dc-83e4-5ed9fd853ba2" /> Adds a nonni role for the Giovanni family, for the nonno and nonna elders of the Clan. They must be 10th generation or older, at least 80 mortal years and 200 immortal years old. Their focus is more on the more secretive business practices of the family, providing hospitality to guests at the manor, and guiding the family youth. There can be two - one on Westfield Mall. Humans and ghouls can also be nonni, maintaining the requirement of being at least 80 years old. ## Why It's Good For The Game An extra layer of hierarchy to showcase the highly organized structure of the family. These ancient souls should help the family with maintaining a public face while still giving time to their dark arts, and add a fun dimension to the family dynamic. Enshrining them officially as a role is a nice way of distinguishing them, as the Giovanni are very respectful of their elders. Seemingly this role does exist in the TTRPG so it should be lore-friendly. ## Changelog :cl: cam_dev add: "I Nonni" role for Giovanni elders /:cl: --------- Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
## About The Pull Request Adds the seizure flaw/deformity from wta20. If you botch a none spammy roll. You get stunned to the floor and shaky. Bounty https://discord.com/channels/1393132000583618701/1517636261798482042 ## Why It's Good For The Game More flaws c: Evetunally used as a required deformity for crinos-born. ## Changelog :cl: add: Seizure Flaw/Deformity /:cl: --------- Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
…ck13#1308) ## About The Pull Request Gives vicissitude horror form ability to see through yourself, this should probably also be extended to garou warforms and such but it's really only the horrid form that makes it hard to see if anyone is a tile above you <img width="304" height="270" alt="Screenshot 2026-07-31 133035" src="https://github.com/user-attachments/assets/0fad3528-34b3-4556-959b-cce2ba177a4f" /> <img width="232" height="244" alt="Screenshot 2026-07-31 133039" src="https://github.com/user-attachments/assets/cfb48744-b9dc-4404-a0cb-da5bac4543da" /> ## Why It's Good For The Game This prevents hitting yourself or unable to hit something when its above you in horrid form ## Changelog :cl: qol: see through can be toggled on the vicissitude horror form /:cl: Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
## About The Pull Request See tgstation/tgstation#97334 This bug was copied from that proc ## Changelog :cl: code: Fixes infinite loop caused by teleport moving while having a looped chain of grabbed mobs /:cl: --------- Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
## About The Pull Request This PR adds the hunter's ID (that is, a gold cross), as a starting loadout item, alongside two new crosses, the silver and gothic crosses. Gold crosses were bumped up to $30, silver crosses are $25, while gothic crosses can be purchased for $20 at the costume store (at least until I get around to making a Hot Topic PR and move it there). You can also wear crosses on your neck or belt. ## Why It's Good For The Game Crosses are certainly one of those things in the United States you'll see everywhere, in great numbers, especially the further back in time you go. It makes sense for anyone to have the option to start with one, especially since religion is such a strong vehicle for manipulation and roleplay in the setting. A small enough proportion of the creatures in the setting are affected by holy symbols to where the people playing them should be ready for them in large numbers anyways, and I think it's more interesting to balance them around this quantity. ## Testing <img width="669" height="382" alt="image" src="https://github.com/user-attachments/assets/f6e1d68a-6623-48cf-861e-1a39443d6618" /> <img width="863" height="312" alt="image" src="https://github.com/user-attachments/assets/fa61bfef-50af-4606-9947-00283029d07a" /> <img width="86" height="78" alt="image" src="https://github.com/user-attachments/assets/3f7360b7-cf1c-49cb-9485-6fc54b20de75" /> <img width="69" height="85" alt="image" src="https://github.com/user-attachments/assets/670b4649-61c3-49b0-b44d-a123783301a4" /> <img width="73" height="75" alt="image" src="https://github.com/user-attachments/assets/6c41c1a8-40f6-425f-b7c2-d2ade37faafc" /> ## Changelog :cl: cam_dev add: added crosses to loadout menu qol: crosses can be worn on belt and neck image: added two new cross sprites /:cl:
## About The Pull Request Ports a PR from TFN's github that I made adding brass knuckles to the illegal vendors. These add unarmed efficiency and unarmed damage when worn by the user, letting them do more damage when unarmed punching when worn. Spiked knuckles are given to the Baron currently, though could instead just be taken and added to the supply console etc instead if preferred. The functional difference between it and brass knuckles is just that spiked ones have pointy damage akin to a spear to the user's unarmed punches. ## Why It's Good For The Game Adds more unarmed viability to the game, was tested and seemed positive response over on TFN to brass knuckles. ## Changelog :cl: add: Adds brass knuckles to the game and illegal vendor. add: Adds spiked knuckles to the Baron. /:cl: --------- Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request I've been using this trait and it feels a bit.. too strong. A person standing 4 tiles away from me can be heard with full clarity, as the 'hearing distance' is effectively the number assigned +1 With this change it changes it from clear coherent hearing at 4 tiles apart down to 2. So you can hear whispers clearly 1 extra tile away, and jarbled ones at another tile after that. This change does nerf it but it feels still useful, given even if you can't hear full whispers ~3 tiles away from you, you get some of the jarbled text to match it up. ## Why It's Good For The Game This made whispering really pointless with how many people can hear it. Sure, there's a level of masquerade to it but it makes entire non-masq breaching things whispered heard by a lot of people due to how cheap the trait is. I feel either this should be merged, or a increase in the merit's cost if it has that range. ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and its effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: balance: Reduces bonus tiles on acute hearing from 3 to 1 (hearing whispers 4 tiles away down to 2) /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
## About The Pull Request Syncs us back up with TG at https://github.com/tgstation/tgstation/blob/master/tools/ci/install_byond.sh The website is missing versions we need and is depricated. <img width="866" height="236" alt="image" src="https://github.com/user-attachments/assets/344eb528-e87d-453c-b8c7-ab8b206a731a" /> And it ought to be a FALLBACK instead of the main option anyway. I will go and pr a fallback url to TG.
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the Apocrypha XIII Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
Author
|
Still doing stuff shite |
Author
|
wait I think this is the wrong pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Language prefixes weren't working and it turns out it was cause there was conflicting keys. So I disabled all the old ss13 languages.
also made it so crinos form of garou can speak primal tongue, same with hispo and lupus.
Why It's Good For The Game
Uhm Bug fixes
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: Added new mechanics or gameplay changes
add: Added more things
del: Removed old things
qol: made something easier to use
balance: rebalanced something
fix: fixed a few things
sound: added/modified/removed audio or sound effects
image: added/modified/removed some icons or images
map: added/modified/removed map content
spellcheck: fixed a few typos
code: changed some code
refactor: refactored some code
config: changed some config setting
admin: messed with admin stuff
server: something server ops should know
/:cl: