ci: assert every Postgres-gated package executed tests (APA-83 P10)

[Aparnap2]

Why

make integration runs only ./internal/repository/postgres/... ./internal/adapters/..., and the anti-fake-green step counted --- PASS for internal/repository/postgres alone. Eight further packages gate on TEST_POSTGRES_DSN and self-skip when it is absent.

The measured gap

With Postgres absent on main@93219b1:

silent skips across the 10 gated packages	60
internal/repository/postgres	0 pass / 20 skip
aggregate passes from the other nine packages	532

That 532 is the whole argument. An aggregate >= 1 — or even >= 100 — threshold passes with Postgres completely down. The previous single-package count was the only thing preventing that.

With Postgres up, the same set runs: internal/repository/postgres 20 pass / 0 skip, and the aggregate rises to 579.

Fix

scripts/ci/check_pg_gated_packages.py runs each required package verbosely and requires at least one passing test per package. Per-package is the point — a busy package cannot mask a silent one.

It also fails closed on an unset TEST_POSTGRES_DSN before running anything, so an unset variable cannot masquerade as coverage.

Evidence

Positive (Postgres up):

         ok  ./internal/repository/postgres  pass=20 skip=0
         ok  ./internal/ingest                pass=16 skip=0
         ... all 10
PASS: all 10 Postgres-gated packages executed tests.   EXIT: 0

Negative 1 — DSN unset: exits 1 before running any test.

Negative 2 — DSN set but Postgres unreachable: exits 1, and the report is the proof:

         ok  ./internal/worker                       pass=62 skip=5
  UNDER-RUN  ./internal/repository/postgres  pass=0 skip=20

Nine packages still read "ok" while the service is down. Only the per-package rule catches it.

Negative 3 — unit-level rule tests: a zero-pass package is under-run; a busy package cannot mask a silent one; an absent package entry is under-run.

Enumeration guard (non-vacuous): the unit test re-discovers every package referencing TEST_POSTGRES_DSN and fails if one is missing from the gate. Verified by adding a gated test to an unlisted package — AssertionError: Postgres-gated packages absent from the gate: ['./internal/claims'] — then removing it (passes).

Worth noting: my first attempt at this control was placed on internal/handlers, which was already in the list, and it passed vacuously. Re-run against internal/claims confirmed the guard is genuinely load-bearing.

Residual skips are not Postgres-related

With Postgres up, the remaining skips are gated on external services: localgcp (app), GCW emulator (worker, workflow), live matrix (tools), one APA-59 trajectory (orchestrate). PG coverage itself is fully exercised.

Scope — P10 only

Per the approved scope decision:

• Mockoon excluded — its placeholder startup step and informational-only probe are tracked separately as P12.
• pull_request trigger unchanged — PR-execution and required-check design are a separate proposal (deferred B).
• Branch protection untouched; no existing check weakened.

Other gates

pytest tests/unit 52 passed (8 new) · ruff check . clean · mypy strict clean, now 10 source files · offline go test ./... exit 0 · go test -race on internal/claims clean · gofmt clean · YAML valid.

No live-provider test bodies executed. Release remains NOT QUALIFIED.

Refs APA-83 (P10). Next isolated slice: P12 Mockoon.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: bffcf154-98d3-4506-b82d-851a1342516c

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[Aparnap2]

Re-review of exact head 7601e67: the prior blocking defect is corrected. PackageResult retains the subprocess return code; evaluate() independently rejects nonzero go-test exits even when passing tests exist; and the regression test exercises that mixed pass/nonzero-exit case. Build-error, all-skipped, missing-package, healthy-run, DSN fail-closed, and package-enumeration coverage are present. Scope remains P10 only: Mockoon/P12, deferred pull_request-trigger proposal B, and branch protection are unchanged. Author reports local live-Postgres reproduction and 54 tests passing. Note: GitHub does not permit approving one's own PR, so this is a review comment rather than a formal approval. Release qualification remains NOT QUALIFIED.