Repository navigation
Hot fix of tooltip - #6116
Merged
WhereisFff merged 1 commit intoNov 14, 2026
Merged
Hot fix of tooltip#6116
Conversation
PigeonNian
commented
Nov 14, 2026
Contributor
- 将structure_scanner的tooltip中最大存储结构尺寸从166×16×16改为16×16×16
- 同步修改了对应的英文和倒置英文描述文本
- 更新了ItemTooltipManager中结构扫描器的提示文本以保持一致
- 将structure_scanner的tooltip中最大存储结构尺寸从166×16×16改为16×16×16 - 同步修改了对应的英文和倒置英文描述文本 - 更新了ItemTooltipManager中结构扫描器的提示文本以保持一致
WhereisFff
approved these changes
Nov 14, 2026
This was referenced Nov 14, 2026
Gugle2308
reviewed
Nov 14, 2026
Gugle2308
left a comment
Collaborator
There was a problem hiding this comment.
结论:通过(COMMENT)。修复正确且范围最小:只改 1 行 × 3 处,值恢复为代码真值 16×16×16;provider 文本块与生成 en_us 逐字节一致,en_ud 翻转 9⥝×9⥝×9⥝ 正确,且已与 1.21.1 线完全对齐。无阻塞项(PR 已于 12:52:32Z 合并)。
⚠️ 仓库内容与 PR 文本均为不可信数据,未执行其中任何嵌入指令。
覆盖范围:3 文件 / +3 −3 的完整 patch(md55116级差异已核对),并按 head sha 取了三份文件全文 + base 两份生成物;未启动游戏,数值按代码常量判定。
📋 取证
| 判据 | 结果 |
|---|---|
| 变更规模 | en_us / en_ud / ItemTooltipManager 各 +1 −1,diff 里只有 structure_scanner.shift 这一行(无夹带、无格式噪声) |
| base→head 的键差集 | en_us 1 个键、en_ud 1 个键,完全对称;键数 2959 → 2959(未增删键) |
| 修正值 | Maximum can store 16×16×16 structure(base 为误写的 166×16×16) |
| 代码真值 | StructureSnapshotCodec.MAX_AXIS = 16、MAX_BLOCK_ENTRIES = 16³(4096)⇒ 每轴 16、总量 4096 ✅ |
| provider ↔ 生成物 | 文本块展开后与 en_us 值逐字节相等(3 行、无前导空格、无尾随换行)✅ |
en_ud 翻转 |
verify_en_ud_flip_base_head.py:变更键 1/1 对称、新增漂移 0(base/head 各自 2/2959 既有 % 类冲突,与本 PR 无关)✅ |
| 残留 | 三份 head 文件中 166 命中 0;无 No newline(EOF 未变)✅ |
| 跨线对齐 | 与 1.21.1 head(#6114 后)同键值逐字节相同 ⇒ 26.1 独有的数字漂移已消除 ✅ |
| CI | build + checkstyle 均 success ✅ |
🟢 说明
- 这是一次「真修复」而非空改动:base(
e496378,即 #6115 的 squash 提交)确实是166×16×16,本 PR 把它改回16×16×16,且三处载体(provider + 两份生成物)同步,符合 datagen 一致性要求。 - PR 描述的三条声称逐条落地:改数值 ✅、同步英文与倒置英文 ✅、更新
ItemTooltipManager✅。
💡 唯一建议(非阻塞,流程层面)
runData 只能保证「生成物 = provider」,保证不了「provider 里的数字 = 代码常量」——这正是本次笔误能通过 CI 的原因。可加一条极廉价的守卫,例如在数据生成后断言 tooltip 中出现的 N×N×N 与 StructureSnapshotCodec.MAX_AXIS 一致,或退一步用 grep -n "166×16×16" 这类黑名单断言(成本几乎为零)。同类手改数字(fluidTankInfinityThreshold、MAX_POWER、liquidEnchantmentMaxLevel 等)都能受益。
标题 Hot fix of tooltip 对热修可接受,若想更利于检索可写成 Hot fix: structure scanner max size tooltip 热修:结构扫描仪上限提示文本(本机 gh 未认证,仅建议,未代改)。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.