Repository navigation
perf(verify): drop the scaffold-lint journey that scaffold-checks already covers - #30
Merged
Merged
Conversation
…pecheck, lint or knip fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Goal: make this template's CI and its verify-template run as fast as reasonable, without losing a check. The run is done when every fix is measured and in its own PR against main with before and after numbers, the checks are green, and the review gate has passed.
The
scaffold-lintjourney creates a module and runstypecheck,lintandknipin it.scaffold-checkssits in the sametoolingfeature and runspnpm run checks, which includes all three. So the verify run scaffolds and installs a module only to repeat checks it already does. This PR removesscaffold-lint.What changed
scaffold-lintjourney fromverify.config.ts, and removed it fromtooling.mdand from the feature index.scaffold-checksnow also asserts that thecheckssummary skips no step and that no[typecheck],[lint]or[knip]failure block appears. Before, it checked only the exit code, so a scaffold whosechecksskipped lint still passed.tooling.mdsays whatscaffold-checksnow proves.Scope
scaffold-lint-rejectsstays, because it proves the configs reject bad code.Blast Radius
This affects only agents that verify this template. A typecheck, lint or knip break still fails the
toolingfeature: either at the first commit's hook or atpnpm run checks.Verification
new --allwith every feature), 5 interleaved rounds per side, tooling-configs 0.3.4. Median CPU (user+sys) went from 109.7 s to 99.3 s, which is −9.5%. Median wall time went from 54.4 s to 49.3 s, but the wall ranges overlap. Every run passed.debuggerstatement and an unused export.scaffold-checksfailed on each one.mappasses, andpnpm run checkspasses 8 of 8.scaffold-checksalready runs, and the journey did its own scaffold and install (steps 01 to 05 of its evidence).checksscript set toANTELOPEJS_CHECKS_SKIP=lint antelopejs-checks. The old head passesscaffold-checkswithChecks: 7 passed, 0 failed, 1 skipped., and the new head fails it at "no step was skipped". The same skip plus adebuggerstatement fails earlier, at the first commit's lint hook. The unseeded journey passes.