Skip to content

perf(verify): drop the scaffold-lint journey that scaffold-checks already covers - #30

Merged
Upd4ting merged 2 commits into
mainfrom
perf/drop-scaffold-lint-journey
Nov 7, 2026
Merged

Upd4ting merged 2 commits into
mainfrom
perf/drop-scaffold-lint-journey

Conversation

@Upd4ting

@Upd4ting Upd4ting commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

Why

Goal: make this template's CI and its verify-template run as fast as reasonable, without losing a check. The run is done when every fix is measured and in its own PR against main with before and after numbers, the checks are green, and the review gate has passed.

The scaffold-lint journey creates a module and runs typecheck, lint and knip in it. scaffold-checks sits in the same tooling feature and runs pnpm run checks, which includes all three. So the verify run scaffolds and installs a module only to repeat checks it already does. This PR removes scaffold-lint.

What changed

  • Removed the scaffold-lint journey from verify.config.ts, and removed it from tooling.md and from the feature index.
  • scaffold-checks now also asserts that the checks summary skips no step and that no [typecheck], [lint] or [knip] failure block appears. Before, it checked only the exit code, so a scaffold whose checks skipped lint still passed.
  • tooling.md says what scaffold-checks now proves.

Scope

  • Only the verify skill's own layer changes. The template that users get does not change.
  • scaffold-lint-rejects stays, because it proves the configs reject bad code.

Blast Radius

This affects only agents that verify this template. A typecheck, lint or knip break still fails the tooling feature: either at the first commit's hook or at pnpm run checks.

Verification

  • Full verify (new --all with every feature), 5 interleaved rounds per side, tooling-configs 0.3.4. Median CPU (user+sys) went from 109.7 s to 99.3 s, which is −9.5%. Median wall time went from 54.4 s to 49.3 s, but the wall ranges overlap. Every run passed.
  • Two independent reviewers seeded a type error, a debugger statement and an unused export. scaffold-checks failed on each one. map passes, and pnpm run checks passes 8 of 8.
  • Numbers were measured with tooling-configs 0.3.4 (build(deps): take tooling-configs 0.3.4 #31) on both sides. The saving, −9.5%, is just under the campaign's 10% bar. It ships because it only deletes a journey whose checks scaffold-checks already runs, and the journey did its own scaffold and install (steps 01 to 05 of its evidence).
  • Seeded break: the template's checks script set to ANTELOPEJS_CHECKS_SKIP=lint antelopejs-checks. The old head passes scaffold-checks with Checks: 7 passed, 0 failed, 1 skipped., and the new head fails it at "no step was skipped". The same skip plus a debugger statement fails earlier, at the first commit's lint hook. The unseeded journey passes.

@Upd4ting
Upd4ting merged commit 3bcd66c into main Nov 7, 2026
7 checks passed
@Upd4ting
Upd4ting deleted the perf/drop-scaffold-lint-journey branch November 7, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant