Repository navigation
docs(readme): document the install template field - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A registry contributor who reads the README should learn about every template field the CLI reads. #14 set
"install": falseon the DMS Starter and DMS Connect Demo templates, but the optional-field list in "Project template metadata" named onlydescription,packageManagerandnextSteps.This adds
installto that list. The wording is the TSDoc ofTemplate.installin the CLI:falsecopies the template and installs nothing on the host, for a template that installs its own dependencies (for example in its container). Absent ortrueinstalls the dependencies on the host.Related issue
ANT-1817 (internal task). Follow-up to #14.
Verification
The CLI code that reads the field, at
AntelopeJS/antelopejs@d6cbc9f:src/cli/catalog-manifest.tslines 24-30 declare and document it:Lines 200 and 209 validate and pass it through:
src/cli/commands/module/init-action.tslines 226-228 decide host installation from it:Repo check: the
Documentationworkflow's action (AntelopeJS/tooling-configs/actions/docs@310e3d8) run locally on this branch:Checklist