Repository navigation
feat(templates): list the DMS Adonis project template - #10
Merged
Merged
Conversation
Member
Author
|
Verdict: PASS+NOTES (fresh verifier, head
Notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Lists the AdonisJS template as the project template DMS Adonis in
manifest.json(projectTemplates), with its repository, branch, package manager and next steps, and mentions it in the README next to DMS Demo.ajs project init my-app --template "DMS Adonis"needs@antelopejs/core1.16 or later and the template change in AntelopeJS/template-dms-adonis#23 (it ships theantelope.config.tsplaceholder that makes init keep the template's configuration). Closes AntelopeJS/template-dms-adonis#22 together with that PR.Proof
ajs project init app --template "DMS Adonis" --git-init(core 1.18.0, isolatedHOME) against a copy of this manifest whoserepositorypointed at a local clone of the template change:Found 6 templates, the template was copied and installed,Kept the template's project configuration, and the entry's three next steps were printed.manifest.jsonis valid JSON; the diff only adds the entry.Attention
maincarries the placeholder, scaffolding from this entry fails the way #22 describes.