Repository navigation
build(deps): bump @antelopejs/tooling-configs to 0.5.1 - #85
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Put interface-database on
@antelopejs/tooling-configs0.5.1 and make it pass cleanly, not just carry the new version. 0.5.1 addsantelopejs/no-read-then-insert, relaxesno-inherited-key-lookup, and fixes the declared-surface walk that overflowed the stack on this package (tooling-configs#290). Task ANT-1857, parent ANT-1840.What changed
@antelopejs/tooling-configsis declared^0.5.1, and the lockfile resolves 0.5.1.pnpm run syncrewroteAGENTS.md(new rule row, three sync notes now enforced by--check) and.agents/skills/verify-interface/SKILL.md(verdict --judgement).features/smoke.mdno longer blames the stack overflow.every-functionandminor-bumpnow run here but cannot pass, so the gotcha states the two tool-side reasons andthrough-corestays the smoke journey.No lint finding came up.
no-read-then-insertandno-unknown-parametersreport nothing here. The repo has nono-inherited-key-lookupsuppression for #291 to retire.guardrails.suppressions.jsonis unchanged. No published surface changes.Proof
Before. Main with
^0.5.1installed, beforepnpm run sync:After, at this head:
Verify layer.
antelopejs-verify journey <run> --planran all 20 features (the diff touchespackage.json) and passed 31 of 31 journeys.Attention
Run by hand at this head with
smokenaming them,every-functionandminor-bumpboth fail:every-functionfails 635 checks. 577 are class prototype methods (.:ValueProxy.prototype.gt, and so on). The.d.tswalk lists them and the consumer's runtime walk does not (it returns 65 top-level members), so each reads as "declared but not exported". The other 58 are plain classes and functions that would needinterface.callshooks.minor-bumpreports 21 added and 21 removed__@asyncIterator@<n>members, whose ids differ between the published 0.3.1 build and head (1858 against 3457). Each signature also embeds its referenced type closure, so fix(selection): accept a getAll key proxy of any SelectionKey type #80's realgetAll<K extends SelectionKey>overload marks 630 functions as changed. With symbol ids normalised, 42 still differ, all through that overload. That part is genuine: under the rule, the next release of this package needs at least 0.4.0.