Repository navigation
build(deps): bump @antelopejs/tooling-configs to 0.5.1 - #109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Put this repository on
@antelopejs/tooling-configs0.5.1 and adopt itsantelopejs/no-read-then-insertcheck (tooling-configs#287), which catches a read that decides an insert another replica can race. 0.5.1 also relaxesantelopejs/no-inherited-key-lookup(tooling-configs#291) and narrowsanti-slop/no-unknown-parametersto trust only schema-library decoders (tooling-configs#281). Part of ANT-1663. This is this repository's 0.5.1 bump for ANT-1840.What changes
@antelopejs/tooling-configsgoes from^0.5.0to^0.5.1, and the lockfile resolves 0.5.1.pnpm run syncupdated the managedAGENTS.mdblock, which adds theno-read-then-insertrow and moves threeskipLibCheck/typecheckrows toantelopejs-sync --check. It also updated.agents/skills/verify-interface/SKILL.md, whereverdictnow takes--judgement <file>.errorin the preset thatoxlint.config.tsextends, so thelintstep of CI runs it with no config change. The preset turns it off for test files.No source file changes.
Findings from main with 0.5.1
pnpm exec oxlint --report-unused-disable-directiveson main with 0.5.1 reports no diagnostics:antelopejs/no-read-then-inserthas no findings. This package declares tables and models and runs no startup read that decides an insert.anti-slop/no-unknown-parametershas no new findings. Its 8 existing directives still suppress live diagnostics, so none is unused.no-inherited-key-lookuprelaxation frees no directive, because the repository has none for that rule.No fix was needed, so there is no before and after test.
guardrails.suppressions.jsonis unchanged, and noguardrails.ratchet.jsonwas needed.Note on ANT-1709 (not fixed here)
HashModifier.lockinsrc/modifiers/hash.tscallsscryptSyncon every write of a hashed field. ANT-1709 measured about 135 ms of event-loop block per password write. I think this deserves its own task. The fix is not local, becauselockruns inside the synchronous setter and theinsert/updateconversions. Moving the hash to the thread pool needs an async lock path through the modifier chain, which changes the exported modifier contract. That is a minor bump of this interface, and it needs a matching change in the implementing modules.testAsyncalready exists for the read side, so only the write path remains.Proof
pnpm run checks(typecheck, lint, format, knip, tests, size, suppressions, sync check, verify types and lockfiles):Exported surface unchanged:
API: 1 packages, 25 entries unchanged against origin/main (committed HEAD).
API: skipped .agents/skills/verify-interface, private.
Runtime API: 1 packages, 13 entries unchanged against origin/main (committed HEAD).
No behavioural probe ran.
Suppressions in authored code files (origin/main and committed HEAD). A lint directive counts once per rule it names;
*is a directive naming none.anti-slop/no-unknown-parametersanti-slop/no-unknown-returnsanti-slop/no-unsafe-dictionary-typetypescript/no-unnecessary-type-parameterstypescript/no-unsafe-assignmenttypescript/no-unsafe-return@ts-expect-error@ts-ignoreSAFETY:comments