Repository navigation
fix(release): regenerate the module README table when the interface bumps - #195
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
antelopejs-syncwrites the dependency table inpackages/dms-builder/README.md, and its "Tested with" column reads the workspace interface version. The interface release bumpspackages/interface-dms-builder/package.json, but itsafter:bumphook staged onlyCHANGELOG.md. So the release commit left the README stale and failedsync:check. Same bug as AntelopeJS/dms#855. The hook now matches dms-saas and dms-media:"hooks": { - "after:bump": "git add CHANGELOG.md" + "after:bump": ["pnpm --dir ../.. run sync", "git add -u ../..", "git add CHANGELOG.md"] }Evidence
Before: the release commit 09b1e98 (
chore(release): @antelopejs/interface-dms-builder v0.4.1) failedci. Reproduced locally on that commit:Running
antelopejs-syncthere shows the drift:After: I ran the real
pnpm releasein a scratch worktree at 44379bc (the commit before the 0.4.1 release), with this config committed on top. I passed the shared workflow's arguments (--ci --git.requireBranch=<branch> --git.tagExclude=*.*.*-* --plugins.release-it-changelogen.from=interface-v0.4.0) plus--git.requireUpstream=false --git.tag=false --git.push=false --github.release=false --npm.publish=false, so it made only a local commit:pnpm run checkson that release commit:pnpm run checkson this branch:Checks: 12 passed, 0 failed.Merge Danger
Door: two-way. Only the interface release hook changes.
Blast Radius: release-only. It affects the next interface release commit, which will also carry any other tracked file that
antelopejs-syncrewrites.