Repository navigation
build(deps): bump @antelopejs/tooling-configs to 0.5.1 - #194
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This puts dms-builder on
@antelopejs/tooling-configs0.5.1 so the repo is checked by the new guardrails and passes them, not just carries the new version number (ANT-1845, parent ANT-1840). 0.5.1 addsantelopejs/no-read-then-insert(tooling-configs#287) and relaxesantelopejs/no-inherited-key-lookupto accept Object.prototype guards (tooling-configs#291).What changed
@antelopejs/tooling-configsis declared^0.5.1in the root and inpackages/dms-builder, and both lockfiles are updated.pnpm run syncrewrote the managed guardrails table inAGENTS.md. It adds theno-read-then-insertrow and moves threeskipLibCheckandreleaserows from "note only" toantelopejs-sync --check.New findings
None.
no-read-then-insertis on for non-test files and fires on a throwaway probe (getAll()theninsert()on one model) inpackages/dms-builder/src. The repo's non-test source makes noinsert,insertOneorinsertManycall, so nothing matches it. No suppression namesno-inherited-key-lookup, so #291 frees none to remove.guardrails.suppressions.jsonis unchanged.Proof
Before means
origin/main(13fa89b) with the bump, install and sync applied and no other change. After means the committed head. The trees are identical, because no fix was needed.pnpm run sync:check, before:pnpm run checks, before:pnpm run sync:check, after:pnpm run checks, after:Verify layer,
pnpm --dir packages/dms-builder/frontend-vue typecheck:CI race (exists on main, tracked separately)
CI run 42865519579 failed
ci / Node .nvmrcon attempts 1 to 3 withFound 0 warnings and 2511 errorsfrom oxlint, all of the "error typed value" kind. Attempt 4 passed (Checks: 12 passed, 0 failed). Main fails the same way at 13fa89b and c16bfa5, and passed at da213a8.antelopejs-checksrunstypecheckandlintconcurrently. Heretypecheckbuilds the interface (rimraf dist && tsc), and oxlint reads@antelopejs/interface-dms-buildertypes from thatdist. When lint reads first, every interface type resolves toerror. Lint with the interfacedistmoved aside reproduces every CI finding locally, and lint with it present reports none.This PR stays a bump only. The step-ordering fix is tracked in a tooling-configs task.