Repository navigation
Fix stale selections when filling select controls - #958
Open
peterolkhov wants to merge 1 commit into
Open
peterolkhov wants to merge 1 commit into
peterolkhov wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #957.
Proposed Changes
fill_formcurrently adds selections to a select without removing existing ones. For example, a multiple select with defaulta, filled with['b'], renders bothaandbselected; filling it with[]leavesaselected.Clear the existing option selections before applying a supplied value. This also preserves the existing first-match behavior for scalar values. Missing and
Nonevalues, skipped controls, unrelated attributes, and other form controls retain their current behavior.The change is made in the source notebook and exported to
components.py. Notebook tests cover replacement, clearing, defaults, scalar duplicates, preserve controls, and the adjacent form controls.Types of changes
Checklist
Additional Information
Prepared with OpenAI Codex. The added component notebook test fails on unchanged upstream and passes with the fix. Validation used Python 3.12.13: the focused notebook and full
nbdev-test --n-workers 0pass, along withnbdev-export,nbdev-clean, andnbdev-trust. A second export/clean leaves the changed files unchanged. The full test run honors the project's existingskip_execdirectives; no browser submission, external provider, or deployment test was run.