🎨 Palette: Add ARIA labels to icon-only buttons - #4
Conversation
Co-authored-by: Amer-alsayed <99971255+Amer-alsayed@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2482d602b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {/* Floating Scroll-to-Bottom Button / Typing Indicator */} | ||
| <button | ||
| className={`scroll-to-bottom-btn glass ${(!isLastMessageVisible && !isInlineTypingVisible) ? 'visible' : ''} ${(activeContact.isTyping && !isInlineTypingVisible) ? 'typing-active' : ''}`} | ||
| aria-label="Scroll to bottom" |
There was a problem hiding this comment.
When this floating button is in the typing state (activeContact.isTyping && !isInlineTypingVisible) or shows localUnreadCount, the new static aria-label supplies the entire accessible name, so assistive tech ignores the visible “{username} is typing...” text and unread badge. Screen-reader users will only hear “Scroll to bottom” while sighted users get the typing/unread status; make the label dynamic or expose the status separately, such as with an aria-live region.
Useful? React with 👍 / 👎.
1 participant
Adds ARIA labels to all icon-only buttons across the chat application to improve accessibility for screen readers.
💡 What:
Added descriptive
aria-labeltags to icon-only interactive elements inChatArea.jsx,Sidebar.jsx, andCallWindow.jsx. Also included an update in.Jules/palette.mdfor journal logs tracking the UX accessibility finding.🎯 Why:
Users who rely on screen readers were unable to determine the purpose of multiple icon-only action buttons within the interface (e.g. Play/Pause voice note, attach files, maximize call). This change allows assistive technologies to announce their functionality clearly.
📸 Before/After:
Before:
<button onClick={onBack}><ArrowLeft /></button>After:
<button aria-label="Back to menu" onClick={onBack}><ArrowLeft /></button>♿ Accessibility:
Ensures keyboard accessibility and screen reader friendliness across multiple core components of the application.
PR created automatically by Jules for task 118623696369727103 started by @Amer-alsayed