π‘οΈ Sentinel: [CRITICAL] Fix insecure JWT secret fallback in production - #1
π‘οΈ Sentinel: [CRITICAL] Fix insecure JWT secret fallback in production#1Amer-alsayed wants to merge 1 commit into
Conversation
Co-authored-by: Amer-alsayed <99971255+Amer-alsayed@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: The server fell back to a hardcoded development JWT secret (DEFAULT_DEV_SECRET) if process.env.JWT_SECRET was missing in production mode. This allowed production apps to boot with a widely-known, predictable secret, completely breaking JWT validation and authentication (auth bypass / token forgery).
π― Impact: An attacker could trivially sign arbitrary JWT tokens to impersonate any user on the platform by using the open-source dev secret.
π§ Fix: Updated server/src/config.js to log a CRITICAL error and immediately exit (process.exit(1)) if JWT_SECRET is missing in production. Also updated .jules/sentinel.md with this finding.
β Verification: Start server with NODE_ENV=production node server.js and verify it instantly crashes with an error. Start it with NODE_ENV=production JWT_SECRET=foo node server.js and verify it starts normally.
PR created automatically by Jules for task 6214335384014386853 started by @Amer-alsayed