Conversation
Prepare for --streaming mode (#780): split Upload/Download/Restore into prologue, per-table body and epilogue, extract createOneTable, uploadOneTable, restoreOneTable, saveLocalBackupMetadata and a removeTableLocal helper. Behavior of existing commands is unchanged.
…780 create_remote --streaming pipelines freeze -> upload -> remove local copy per table, restore_remote --streaming pipelines download -> attach -> remove local copy per table. The create/upload and download/restore contracts stay the on-disk layout plus per-table metadata.json; the orchestrators reuse the extracted per-table steps. Streaming runs keep their own resumable state files: create_upload_streaming.state2 and download_restore_streaming.state2. watch --streaming / server --watch-streaming pass the mode through to create_remote. Also bump Dockerfile builder to golang:1.27-alpine to match go.mod.
Old 1.x ClickHouse has no {database}/{table} macros and no two-argument
numbers(): substitute the macros only when getMacro is absent (same check
as createTestSchema) and use number + offset FROM numbers(rows).
Coverage Report for CI Build 33858353957Coverage increased (+0.4%) to 66.816%Details
Uncovered Changes
Coverage Regressions20 previously-covered lines in 10 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #780