Repository navigation
Update 02841_parquet_filter_pushdown reference for nullable min/max pruning - #2822
Merged
filimonov merged 1 commit intoNov 10, 2026
Conversation
…runing #2657 (a756181) lets Parquet row-group pruning skip a nullable column whose non-null range misses the predicate, so the five `-- quirk with infinities` queries now read only the row groups a non-nullable column would. The reference still carried the over-reading values; the sequential stateless jobs were dropped on that PR, so the mismatch surfaced on the next PR. Verified with a local A/B of the same ASan build with the PR 2657 source change reverted: the old reference passes there, the new one passes with the change, and the real (non-indexHint) filter results are identical on both. CI: https://altinity-build-artifacts.s3.amazonaws.com/json.html?PR=2805&sha=ad04f95e44190bff34b9e5330054a01abaa848ec&name_0=PR PR: #2805 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Mikhail Filimonov <mfilimonov@altinity.com>
ianton-ru
approved these changes
Nov 9, 2026
Member
|
should it have port-antalya label? |
Member
|
@filimonov either pls add a |
|
Here's a fix for test only, no code was touched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
02841_parquet_filter_pushdownfails in the sequential stateless jobs onantalya-26.8since #2657 (nullable min/max pruning): five-- quirk with infinitiesqueries now read only the row groups a non-nullable column would, and the reference still has the old over-reading values. The sequential jobs were dropped on that PR, so the diff surfaced on the next one.Update the reference and the three comments. Verified with an A/B on one ASan build with the PR 2657 source change reverted: the old reference passes there, the new one passes with the change, and the real (non-
indexHint) filter results are identical on both.Related: #2657
CI: https://altinity-build-artifacts.s3.amazonaws.com/json.html?PR=2805&sha=ad04f95e44190bff34b9e5330054a01abaa848ec&name_0=PR (jobs "Stateless tests (amd_debug, sequential)" and "Stateless tests (amd_debug, distributed plan, s3 storage, sequential)")
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: