Antalya 26.6: Bump to 26.6.4 - #2309
Open
zvonand wants to merge 324 commits into
Open
Conversation
…g AggregateFunction columns at DDL time
…7366 Backport ClickHouse#107366 to 26.6: Reject TTL expressions referencing AggregateFunction columns at DDL time
…applied in some cases
…n sorted path order
…ightweight snapshot creation
…icy AST in place in `Merge`
… large kafka_num_consumers
… the split filter column name clashes with an input
…lineage field ids in native Parquet reader
…-index matching over a large dotted constant
…7377 Backport ClickHouse#107377 to 26.6: Tolerate Iceberg v3 reserved row-lineage field ids in native Parquet reader
…3390 Backport ClickHouse#113390 to 26.6: Fix ATTACH of Kafka tables with a large kafka_num_consumers
…gMetadata::iterate when datalake_table_state is missing
…le with an inconsistent bloom filter size
…mit::query_map causing LOGICAL_ERROR
On 26.6, `EXPLAIN indexes = 1` does not print the combined `Parts: 0 | Granules: 0` summary line that master's pretty plan formatting emits, so the backported reference had one extra line. The meaningful assertion — the JSON subcolumn index still prunes, `Granules: 0/1000` — is unchanged. CI: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=114476&sha=9a63cb20d13792992441770495ca5610ca25ca62&name_0=BackportPR&name_1=Stateless%20tests%20%28amd_asan_ubsan%2C%20distributed%20plan%2C%20parallel%2C%202%2F2%29 PR: ClickHouse#114476 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Two stateless tests from ClickHouse#113291 cannot run on 26.6 as cherry-picked, so they fail before any assertion executes. 04672: join_runtime_filter_min_probe_rows does not exist on 26.6 (added by ClickHouse#104860, settings history 26.8), so the SET at line 21 aborts the test with UNKNOWN_SETTING. Dropping that one clause makes the line identical to the merged 26.7 backport. max_bytes_ratio_before_external_join does exist here, so it stays and 04029 needs no change. 04695: the t_utc block was removed from this branch but the trailing DROP TABLE t_utc and the three matching reference lines were left behind, so the test dies with UNKNOWN_TABLE. Both files: EXPLAIN PLAN defaults to actions=1, compact=1, pretty=1 only from 26.7 via explain_query_plan_default, which does not exist on 26.6, so the references written for master do not match. Pinning the three options explicitly restores the byte-exact output. All three are needed: compact and pretty without actions collapse the plan and hide the sort description rows. Verified with clickhouse local on stock 26.6.3.30 and on a master build. On 26.6 both tests now run to completion and every remaining difference is the defect ClickHouse#113291 fixes. On master the same files match the references byte for byte, so the pinning loses no coverage.
This is the only failing gtest on asan_ubsan and tsan. ClickHouse#113291 added the TEST, but the monotonicity it asserts lives in src/Functions/toNullable.cpp and came from ClickHouse#110121, which is labelled pr-performance and was not backported: hasInformationAboutMonotonicity is absent from toNullable.cpp on 26.6 and present on 26.7, which is why 26.7 went green. Separate commit so it can be dropped if ClickHouse#110121 is backported instead.
…2479 Backport ClickHouse#112479 to 26.6: RabbitMQ related fix
…2601 Backport ClickHouse#112601 to 26.6: Iterate ColumnObject subcolumns in sorted path order
…icas read when the requested stage cannot absorb finalized data
This reverts commit d7e0987.
… over a `Merge` table returning no rows for children that read from other tables
…serialization `TextIndexPostingsDeserializationTest` constructed `PostingsSerialization` with a null codec, but in 26.6 the constructor has `chassert(posting_list_codec)`, so the test aborted in builds with sanitizers, where `chassert` is active (on `master` the test goes through `PostingListCodecNone` directly and never constructs `PostingsSerialization`). Pass the `None` codec instead: a posting list without the `IsCompressed` flag never consults it, so the tested code path is the same. Unit tests (tsan): https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=116535&sha=e71cd5c2e4bb1ed299b4fb5feaaf87db7a350d94&name_0=BackportPR&name_1=Unit%20tests%20%28tsan%29 Related: ClickHouse#116535
…5334 Backport ClickHouse#115334 to 26.6: Do not let SET <name> = DEFAULT bypass the settings constraints
…8256 Backport ClickHouse#108256 to 26.6: Do not use projections for distributed reads in make_distributed_plan
…6371 Backport ClickHouse#116371 to 26.6: Fix a `_table`/`_database` filter over a `Merge` table returning no rows for children that read from other tables
…7511 Backport ClickHouse#107511 to 26.6: Fix LOGICAL_ERROR on UNION subquery with INTERSECT/EXCEPT children (old analyzer)
…9747 Backport ClickHouse#109747 to 26.6: Avoid server abort on type mismatch during partial result evaluation
…3478 Backport ClickHouse#103478 to 26.6: Push equi-key filter into the left input of RIGHT JOIN for cross-type USING keys
…5700 Backport ClickHouse#115700 to 26.6: Bound the recursion in several parsers and schema readers
… on an empty IN set over a Nullable column
…: guard count compare against empty read
…5222 Backport ClickHouse#115222 to 26.6: Bound text index posting list deserialization
…6538 Backport ClickHouse#116538 to 26.6: Restore short-circuit of a filter on an empty IN set over a Nullable column
Pull in the 26.6 fix for the flaky `test_kafka_formats_with_broken_message` (ClickHouse#116741).
…0480 Backport ClickHouse#110480 to 26.6: Fix flaky 03151_unload_index_race: guard count compare against empty read
… declares in the Native protocol
… a subquery, a CTE, or a view to the settings constraints
…7011 Backport ClickHouse#117011 to 26.6: Do not allocate from sizes a peer declares in the Native protocol
…5397 Backport ClickHouse#115397 to 26.6: Clamp a SETTINGS clause nested in a subquery, a CTE, or a view to the settings constraints
…time zones locally
…5824 Backport ClickHouse#115824 to 26.6: Fix bad projection names
…6851 Backport ClickHouse#116851 to 26.6: `formatDateTime`: Cache resolved time zones locally
…5701 Backport ClickHouse#115701 to 26.6: Validate aggregate function states on deserialization
…9764 Backport ClickHouse#109764 to 26.6: fix partition pruning for timestamp type
Release v26.6.4.55-stable
Adapt Antalya-specific code to upstream API changes brought by the 26.6.4 merge: * `StorageObjectStorageConfiguration::partition_strategy_type` is now `private`, so `StorageObjectStorage::read` uses the public accessor `getPartitionStrategyType` instead. * `DatabaseDataLake` keeps its settings in `MultiVersion<DatabaseDataLakeSettings> database_settings` rather than a plain `settings` member. `getCatalog` and `getConfiguration` still referred to `settings`; they now take a version and alias it the same way the rest of the file does. * The new `gtest_rest_catalog` tests construct `RestCatalog` and `OneLakeCatalog` with the upstream signatures, which lack the Antalya `namespaces_` argument, and call `tryGetTableMetadata` without the Antalya `ContextPtr`. Pass both. Only the first error appeared in the CI report because `ninja` stopped before reaching the others. CI report: https://altinity-build-artifacts.s3.amazonaws.com/json.html?PR=2309&sha=feba0a23cfd061a10d92b9b53056e7efbf3188cf&name_0=PR&name_1=Fast%20test Related: #2309
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
CI/CD Options
Exclude tests:
Regression jobs to run: