Repository navigation
fix(studio): refuse an empty run scope, and resolve a run once before it starts - #526
Merged
Merged
Conversation
… it starts A line of 0 or an empty tag is no longer read as the whole file: run_file and the MCP tool refuse it, and a line or tag that is left out is not sent. The run slot is now claimed before runFileAsync returns, so a second start is refused by the call instead of being dropped in the background, and the scope is resolved once. Tests: a failed test that has been renamed or removed is left out of a failed-only re-run; a composite test is selected by its name only when the run names it; an explicit line of 0 and an empty tag are refused; a start while a run holds the slot returns the refusal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lineof 0 or an emptytaginrun_fileand in the MCP toolstudio_run_fileis refused, not read as the whole file. Left-out fields are still not sent.runFileAsyncclaims the run slot before it returns, so a second start is refused by the call. It used to be dropped silently in the background. The scope is resolved once, and the background run uses that resolution. The error from that resolution is no longer dropped.Test plan
go vet ./...andgo test ./...instudio, including the new scope and slot testsTestFailedOnlyLeavesOutATestThatIsGonego vetandgo test ./internal/mcp/... ./internal/runner/...at the repo root🤖 Generated with Claude Code